[Fix] Lose OriginatingApp Connection on Save As

[ThomThomson]

Summary

Closes #72429 by restoring the flow from 7.8. When a user has redirected to an editor from a container, then used the 'save as' button and chosen not to return to the originating app, the connection to that app should be severed.

How to test

• Edit a panel from a dashboard OR create a new panel from dashboard
• Once you are in the editor, use the modal (save as), to save the visualization / lens visualization
• Deselect add to dashboards after saving select save as new visualization then save.
• The originatingApp connection should now be lost, and the top nav menu should only display save

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] This was checked for keyboard-only and screenreader accessibility
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
- [ ] This was checked for cross-browser compatibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[ThomThomson]

@elasticmachine merge upstream

[flash1293]

Tested in Firefox for both Lens and Visualize:

• Create new from dashboard, save without returning
• Edit from dashboard, save as new without returning

In both cases, the app behaves as if there is no dashboard connection afterwards.

I feel a bit weird about using a mutable local variable which just happens to get picked up by the next render cycle triggered by the subsequent push, but I can't think of a better way for now. Thanks for the functional tests here! We can address this when improving state management overall.

LGTM

[ThomThomson]

As I looked over it again, I also felt a little weird mutating the variable in mounter.tsx, so I added originatingApp to the state of app.tsx, and used that instead. It will still have to be revisited later most likely, but it now feels much better!

[majagrubic]

Tested in Chrome on Mac OS for following scenarios:

• created a new visualization from dashboard, save and add to dashboard
• created a new visualization from dashboard, saved it without adding to dashboard

I can confirm the regression is gone. Looking at the code now.

[majagrubic]

Code LGTM

[flash1293]

I think now something is broken. When I edit a Lens vis from the dashboard and use "Save as" without "return to dashboard", it will still show the "Return to dashboard" switch in the modal when I try to save again.

[ThomThomson]

Good catch @flash1293, that was caused by a typo which has been fixed in the latest commit.

[flash1293]

Tested and works fine, LGTM

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 7f92739

Build metrics

async chunks size

id	value	diff	baseline
lens	24.9KB	+199.0B	24.7KB
visualize	677.3KB	+260.0B	677.0KB
total	-	+459.0B	-

History

• 💚 Build #63704 succeeded 75decfb
• 💚 Build #63607 succeeded 04cca1e
• 💔 Build #63405 failed d308371

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream