Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Lose OriginatingApp Connection on Save After Create new #74420

Conversation

ThomThomson
Copy link
Contributor

Summary

Closes #74400 by fixing a small typo made in #72725. This typo resulted in the originatingApp connection not being severed after the user saved a newly created visualization and had not specifically checked the save as new visualization button.

How to test

  • create a new panel from dashboard
  • Once you are in the editor, use the modal (save), to save the visualization / lens visualization
  • Deselect 'return to...' and save.
  • The originatingApp connection should now be lost, and the top nav menu should only display save

Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] This was checked for keyboard-only and screenreader accessibility
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
- [ ] This was checked for cross-browser compatibility

For maintainers

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.9.1 labels Aug 5, 2020
@ThomThomson ThomThomson requested a review from a team August 5, 2020 20:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
lens 25.0KB -11.0B 25.0KB
visualize 677.3KB -7.0B 677.3KB
total -18.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it on Safari 🎈

@ThomThomson ThomThomson merged commit dad5c72 into elastic:master Aug 6, 2020
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Aug 6, 2020
…c#74420)

Fixed typo created in elastic#72725 which caused the originatingApp connection not to be lost properly after Create new
ThomThomson added a commit that referenced this pull request Aug 6, 2020
#74569)

Fixed typo created in #72725 which caused the originatingApp connection not to be lost properly after Create new
@LeeDr
Copy link

LeeDr commented Aug 10, 2020

@ThomThomson if you merged to 7.x you should add label v7.10.0.

If you want to include in 7.9.x you need another backport to 7.9 branch. If it were already merged to 7.9 branch last week then the label should be v7.9.0. If it goes in later it should stay v7.9.1.

ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Aug 10, 2020
…c#74420)

Fixed typo created in elastic#72725 which caused the originatingApp connection not to be lost properly after Create new
ThomThomson added a commit that referenced this pull request Aug 10, 2020
#74692)

Fixed typo created in #72725 which caused the originatingApp connection not to be lost properly after Create new
@gchaps gchaps mentioned this pull request Aug 31, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.1 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OriginatingApp Connection not lost after Create New
5 participants