-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Lose OriginatingApp Connection on Save After Create new #74420
[Fix] Lose OriginatingApp Connection on Save After Create new #74420
Conversation
…onnection not to be lost properly after Create new
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested it on Safari 🎈
…c#74420) Fixed typo created in elastic#72725 which caused the originatingApp connection not to be lost properly after Create new
@ThomThomson if you merged to 7.x you should add label v7.10.0. If you want to include in 7.9.x you need another backport to 7.9 branch. If it were already merged to 7.9 branch last week then the label should be v7.9.0. If it goes in later it should stay v7.9.1. |
…c#74420) Fixed typo created in elastic#72725 which caused the originatingApp connection not to be lost properly after Create new
Summary
Closes #74400 by fixing a small typo made in #72725. This typo resulted in the originatingApp connection not being severed after the user saved a newly created visualization and had not specifically checked the
save as new visualization
button.How to test
save
Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibility- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser- [ ] This was checked for cross-browser compatibilityFor maintainers