[data.search.aggs]: Expression functions for bucket agg types #64772

alexwizp · 2020-04-29T13:30:28Z

Closes #63762

Summary

In this PR new expression functions were created for the following bucket agg types:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-04-29T15:07:46Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

…s agg types + significant terms

lukeelmers

Overall looks great -- thanks for powering through all of these! I have a few comments, mostly just nits around the help text, and a couple of questions.

The only broader thing I'm noticing is that, looking at agg_type.ts, it seems that customLabel param is also magically appended to every agg type (much like json), unless it is explicitly false.

I think this means that we will need to add a customLabel arg to every expression function as well 🙁

I'm wondering if it makes sense to use a base interface for each of the params to extend from, which can contain some of these global things, e.g.

interface AggParamsFilter extends BaseAggParams {}

But I'm also fine with duplicating them in each interface like we've done for json, it's just a matter of remembering them.

WDYT?

src/plugins/data/public/search/aggs/agg_config.ts

src/plugins/data/public/search/aggs/buckets/terms_fn.ts

src/plugins/data/public/search/aggs/buckets/date_range.ts

src/plugins/data/public/search/aggs/buckets/date_range_fn.ts

src/plugins/data/public/search/aggs/buckets/filter_fn.ts

src/plugins/data/public/search/aggs/buckets/geo_hash_fn.ts

src/plugins/data/public/search/aggs/buckets/geo_tile_fn.ts

src/plugins/data/public/search/aggs/buckets/ip_range.ts

src/plugins/data/public/search/aggs/buckets/ip_range_fn.ts

src/plugins/data/public/search/aggs/buckets/lib/geo_point.ts

Co-authored-by: Luke Elmers <[email protected]>

# Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.daterangekey.from.md # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.daterangekey.md # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.daterangekey.to.md # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.iprangekey.md # src/plugins/data/public/public.api.md # src/plugins/data/public/search/aggs/types.ts

lukeelmers

Overall revisions LGTM, just one more note

src/plugins/data/public/search/aggs/types.ts

VladLasitsa

LGTM!

lukeelmers

Code LGTM! One small nit on customLabels in filters, otherwise no remaining concerns on my end.

lukeelmers · 2020-05-04T22:30:00Z

src/plugins/data/public/search/aggs/buckets/filters.ts

+export interface AggParamsFilters extends BaseAggParams {
+  filters?: Array<{
+    input: Query;
+    label: string;
+  }>;
+}


To make this interface accurate, don't we need to override the customLabels from BaseAggParams here, since AggParamsFilters explicitly sets it to false and therefore it isn't a valid param at all?

alexwizp · 2020-05-05T06:15:15Z

@elasticmachine merge upstream

kibanamachine · 2020-05-05T08:09:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 24b3db5

History

💚 Build #45076 succeeded ece4919
💚 Build #45026 succeeded da334ae
💚 Build #44998 succeeded 999b3f7
💚 Build #44913 succeeded 910c7b9
💚 Build #44879 succeeded 4c8aca9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…c#64772) * [data.search.aggs]: Expression functions for bucket agg types - ranges agg types + significant terms * new portion of changes * add geo_tile_fn * add geo_hash_fn * Update src/plugins/data/public/search/aggs/buckets/filter_fn.ts Co-authored-by: Luke Elmers <[email protected]> * Update src/plugins/data/public/search/aggs/buckets/geo_tile_fn.ts Co-authored-by: Luke Elmers <[email protected]> * Update src/plugins/data/public/search/aggs/buckets/geo_hash_fn.ts Co-authored-by: Luke Elmers <[email protected]> * Update src/plugins/data/public/search/aggs/buckets/ip_range_fn.ts Co-authored-by: Luke Elmers <[email protected]> * Update src/plugins/data/public/search/aggs/buckets/geo_hash_fn.ts Co-authored-by: Luke Elmers <[email protected]> * Update src/plugins/data/public/search/aggs/buckets/geo_hash_fn.ts Co-authored-by: Luke Elmers <[email protected]> * Update src/plugins/data/public/search/aggs/buckets/geo_hash_fn.ts Co-authored-by: Luke Elmers <[email protected]> * create BaseAggParams * add filters_fn * add histogram / date_histogram expression functions * cleanup * terms - order should be optional * add custom label params Co-authored-by: Luke Elmers <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

#65227) * [data.search.aggs]: Expression functions for bucket agg types - ranges agg types + significant terms * new portion of changes * add geo_tile_fn * add geo_hash_fn * Update src/plugins/data/public/search/aggs/buckets/filter_fn.ts Co-authored-by: Luke Elmers <[email protected]> * Update src/plugins/data/public/search/aggs/buckets/geo_tile_fn.ts Co-authored-by: Luke Elmers <[email protected]> * Update src/plugins/data/public/search/aggs/buckets/geo_hash_fn.ts Co-authored-by: Luke Elmers <[email protected]> * Update src/plugins/data/public/search/aggs/buckets/ip_range_fn.ts Co-authored-by: Luke Elmers <[email protected]> * Update src/plugins/data/public/search/aggs/buckets/geo_hash_fn.ts Co-authored-by: Luke Elmers <[email protected]> * Update src/plugins/data/public/search/aggs/buckets/geo_hash_fn.ts Co-authored-by: Luke Elmers <[email protected]> * Update src/plugins/data/public/search/aggs/buckets/geo_hash_fn.ts Co-authored-by: Luke Elmers <[email protected]> * create BaseAggParams * add filters_fn * add histogram / date_histogram expression functions * cleanup * terms - order should be optional * add custom label params Co-authored-by: Luke Elmers <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Luke Elmers <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

alexwizp requested a review from VladLasitsa April 29, 2020 13:31

alexwizp force-pushed the 63762 branch from 4de5588 to 9342e04 Compare April 29, 2020 14:16

alexwizp requested a review from lukeelmers April 29, 2020 14:32

alexwizp self-assigned this Apr 29, 2020

alexwizp added v7.8.0 v8.0.0 Feature:NP Migration Team:AppArch labels Apr 29, 2020

alexwizp added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) release_note:skip Skip the PR/issue when compiling release notes labels Apr 29, 2020

lukeelmers mentioned this pull request Apr 29, 2020

[data.search.aggs]: Expression functions for bucket agg types #63762

Closed

11 tasks

alexwizp marked this pull request as ready for review April 29, 2020 16:04

alexwizp requested a review from a team as a code owner April 29, 2020 16:04

[data.search.aggs]: Expression functions for bucket agg types - range…

77eaef7

…s agg types + significant terms

alexwizp changed the title ~~[data.search.aggs]: Expression functions for bucket agg types - ranges agg types + significant terms~~ [Step 1][data.search.aggs]: Expression functions for bucket agg types Apr 30, 2020

alexwizp added 2 commits April 30, 2020 16:21

new portion of changes

3e64a00

Merge remote-tracking branch 'upstream/master' into 63762

59dbde7

alexwizp force-pushed the 63762 branch from 9342e04 to 59dbde7 Compare April 30, 2020 13:24

alexwizp added 2 commits April 30, 2020 17:40

add geo_tile_fn

4e7b330

add geo_hash_fn

21dd3cc

lukeelmers requested changes Apr 30, 2020

View reviewed changes

alexwizp and others added 6 commits May 1, 2020 11:14

Update src/plugins/data/public/search/aggs/buckets/filter_fn.ts

a19709d

Co-authored-by: Luke Elmers <[email protected]>

Update src/plugins/data/public/search/aggs/buckets/geo_tile_fn.ts

1247040

Co-authored-by: Luke Elmers <[email protected]>

Update src/plugins/data/public/search/aggs/buckets/geo_hash_fn.ts

54ba370

Co-authored-by: Luke Elmers <[email protected]>

Update src/plugins/data/public/search/aggs/buckets/ip_range_fn.ts

7af5fec

Co-authored-by: Luke Elmers <[email protected]>

Update src/plugins/data/public/search/aggs/buckets/geo_hash_fn.ts

3e176e1

Co-authored-by: Luke Elmers <[email protected]>

Update src/plugins/data/public/search/aggs/buckets/geo_hash_fn.ts

0589ebd

Co-authored-by: Luke Elmers <[email protected]>

alexwizp and others added 4 commits May 1, 2020 11:17

Update src/plugins/data/public/search/aggs/buckets/geo_hash_fn.ts

4e783da

Co-authored-by: Luke Elmers <[email protected]>

create BaseAggParams

4c8aca9

add filters_fn

910c7b9

alexwizp changed the title ~~[Step 1][data.search.aggs]: Expression functions for bucket agg types~~ [data.search.aggs]: Expression functions for bucket agg types May 4, 2020

alexwizp added 2 commits May 4, 2020 16:48

add histogram / date_histogram expression functions

7c6a589

cleanup

999b3f7

alexwizp mentioned this pull request May 4, 2020

[data.search.aggs]: Expression functions for metric agg types #64914

Merged

7 tasks

alexwizp requested a review from lukeelmers May 4, 2020 14:30

terms - order should be optional

da334ae

lukeelmers reviewed May 4, 2020

View reviewed changes

src/plugins/data/public/search/aggs/types.ts Show resolved Hide resolved

alexwizp added 2 commits May 4, 2020 18:47

add custom label params

f524122

Merge remote-tracking branch 'upstream/master' into 63762

ece4919

alexwizp requested a review from lukeelmers May 4, 2020 15:58

VladLasitsa approved these changes May 4, 2020

View reviewed changes

lukeelmers approved these changes May 4, 2020

View reviewed changes

Merge branch 'master' into 63762

24b3db5

alexwizp merged commit 6349575 into elastic:master May 5, 2020

alexwizp mentioned this pull request May 5, 2020

[7.x] [data.search.aggs]: Expression functions for bucket agg types (#64772) #65227

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[data.search.aggs]: Expression functions for bucket agg types #64772

[data.search.aggs]: Expression functions for bucket agg types #64772

alexwizp commented Apr 29, 2020 •

edited

Loading

elasticmachine commented Apr 29, 2020

lukeelmers left a comment

lukeelmers left a comment

VladLasitsa left a comment

lukeelmers left a comment

lukeelmers May 4, 2020

alexwizp commented May 5, 2020

kibanamachine commented May 5, 2020

[data.search.aggs]: Expression functions for bucket agg types #64772

[data.search.aggs]: Expression functions for bucket agg types #64772

Conversation

alexwizp commented Apr 29, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Apr 29, 2020

lukeelmers left a comment

Choose a reason for hiding this comment

lukeelmers left a comment

Choose a reason for hiding this comment

VladLasitsa left a comment

Choose a reason for hiding this comment

lukeelmers left a comment

Choose a reason for hiding this comment

lukeelmers May 4, 2020

Choose a reason for hiding this comment

alexwizp commented May 5, 2020

kibanamachine commented May 5, 2020

💚 Build Succeeded

History

alexwizp commented Apr 29, 2020 •

edited

Loading