Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
alexwizp committed May 4, 2020
1 parent 7c6a589 commit 999b3f7
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ describe('agg_expression_functions', () => {
"useNormalizedEsInterval": undefined,
},
"schema": undefined,
"type": "histogram",
"type": "date_histogram",
},
}
`);
Expand Down Expand Up @@ -96,7 +96,7 @@ describe('agg_expression_functions', () => {
"useNormalizedEsInterval": true,
},
"schema": undefined,
"type": "histogram",
"type": "date_histogram",
}
`);
});
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/data/public/search/aggs/buckets/filter_fn.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const aggFilter = (): FunctionDefinition => ({
},
geo_bounding_box: {
types: ['string'],
help: i18n.translate('data.search.aggs.buckets.filter.geo_bounding_box.help', {
help: i18n.translate('data.search.aggs.buckets.filter.geoBoundingBox.help', {
defaultMessage: 'Filter results based on a point location within a bounding box',
}),
},
Expand Down
12 changes: 6 additions & 6 deletions src/plugins/data/public/search/aggs/buckets/histogram_fn.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe('agg_expression_functions', () => {
test('fills in defaults when only required args are provided', () => {
const actual = fn({
field: 'field',
interval: 10,
interval: '10',
});
expect(actual).toMatchInlineSnapshot(`
Object {
Expand All @@ -39,7 +39,7 @@ describe('agg_expression_functions', () => {
"extended_bounds": undefined,
"field": "field",
"has_extended_bounds": undefined,
"interval": 10,
"interval": "10",
"intervalBase": undefined,
"json": undefined,
"min_doc_count": undefined,
Expand All @@ -54,7 +54,7 @@ describe('agg_expression_functions', () => {
test('includes optional params when they are provided', () => {
const actual = fn({
field: 'field',
interval: 10,
interval: '10',
intervalBase: 1,
min_doc_count: false,
has_extended_bounds: false,
Expand All @@ -75,7 +75,7 @@ describe('agg_expression_functions', () => {
},
"field": "field",
"has_extended_bounds": false,
"interval": 10,
"interval": "10",
"intervalBase": 1,
"json": undefined,
"min_doc_count": false,
Expand All @@ -89,7 +89,7 @@ describe('agg_expression_functions', () => {
test('correctly parses json string argument', () => {
const actual = fn({
field: 'field',
interval: 10,
interval: '10',
json: '{ "foo": true }',
});

Expand All @@ -98,7 +98,7 @@ describe('agg_expression_functions', () => {
expect(() => {
fn({
field: 'field',
interval: 10,
interval: '10',
json: '/// intentionally malformed json ///',
});
}).toThrowErrorMatchingInlineSnapshot(`"Unable to parse json argument string"`);
Expand Down

0 comments on commit 999b3f7

Please sign in to comment.