[data.search.aggs]: Expression functions for metric agg types #64914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
VladLasitsa
added
Feature:Aggregations
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
alexwizp
requested changes
May 4, 2020
src/plugins/data/public/search/aggs/metrics/std_deviation_fn.ts
Outdated
Show resolved
Hide resolved
lukeelmers
approved these changes
May 5, 2020
There was a problem hiding this comment.
LGTM, I am going to go ahead and merge so we can get a backport into 7.x today.
@VladLasitsa I added one nit on the help text, which can be addressed as a follow-up later.
| types: ['number'], | ||
| multi: true, | ||
| help: i18n.translate('data.search.aggs.metrics.percentiles.percents.help', { | ||
| defaultMessage: 'Range of percentiles ranks', |
There was a problem hiding this comment.
Suggested change
| defaultMessage: 'Range of percentiles ranks', | |
| defaultMessage: 'Range of percentiles', |
lukeelmers
pushed a commit
to lukeelmers/kibana
that referenced
this pull request
May 5, 2020
lukeelmers
added a commit
that referenced
this pull request
May 5, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63760
Summary
In this PR new
expression functionswere created for the followingmetricagg types:countavgsummedianminmaxstd_deviationcardinalityprecentilespercentile_rankstop_hitderivativecumulative_summoving_avgserial_diffbucket_avgbucket_sumbucket_minbucket_maxgeo_boundsgeo_centroidChecklist
Delete any items that are not applicable to this PR.
For maintainers