[Reporting] Integration polling config with client code #63754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
v8.0.0
release_note:skip
tsullivan
commented
Apr 16, 2020
tsullivan
commented
Apr 16, 2020
| @@ -167,12 +169,10 @@ class ReportListingUi extends Component<Props, State> { | |||
| functionToPoll: () => { | |||
| return this.fetchJobs(); | |||
| }, | |||
| pollFrequencyInMillis: | |||
| JOB_COMPLETION_NOTIFICATIONS_POLLER_CONFIG.jobCompletionNotifier.interval, | |||
| pollFrequencyInMillis: this.props.pollConfig.jobsRefresh.interval, | |||
There was a problem hiding this comment.
this was previously using the wrong config key
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
tsullivan
force-pushed
the
reporting/ui-config
branch
from
6ac25b6 to
6ed210a
Compare
tsullivan
commented
Apr 16, 2020
| PluginInitializerContext, | ||
| NotificationsStart, | ||
| } from '../../../src/core/public'; | ||
|
|
There was a problem hiding this comment.
cleaned up unnecessary "proxied" imports
tsullivan
commented
Apr 16, 2020
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| export { ConfigType } from '../server/config'; |
There was a problem hiding this comment.
A new file for sharing types in server / client. I expect there will be more additions to this in the future when we remove the code from legacy and clean up where types are defined
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Apr 21, 2020
* source new platform for reporting ui config * fix test types * fix type check Co-authored-by: Elastic Machine <[email protected]>
tsullivan
added a commit
that referenced
this pull request
Apr 21, 2020
) * source new platform for reporting ui config * fix test types * fix type check Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 22, 2020
* master: (29 commits) [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611) refactor action filter creation utils (elastic#62969) Refresh index pattern list before redirecting (elastic#63329) [APM]fixing custom link unit tests (elastic#64045) [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103) [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033) [Maps] Map settings: min and max zoom (elastic#63714) [kbn-storybook] Use raw loader for text files (elastic#64108) [EPM] /packages/{package} endpoint to support upgrades (elastic#63629) [SIEM] New Platform Saved Objects Registration (elastic#64029) [Endpoint] Hook to handle events needing navigation via Router (elastic#63863) Fixed small issue in clone functionality (elastic#64085) [Endpoint]EMT-146: use ingest agent for status info (elastic#63921) [SIEM] Server NP Followup (elastic#64010) Register uiSettings on New Platform (elastic#64015) [Reporting] Integration polling config with client code (elastic#63754) [Docs]7.7 SIEM doc updates (elastic#63951) [SIEM] [Cases] Tags suggestions (elastic#63878) Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027) [DOCS] Add file size setting for Data Visualizer (elastic#64006) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 22, 2020
…ana into task-manager/cancel-logging * 'task-manager/cancel-logging' of github.com:gmmorris/kibana: (28 commits) [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611) refactor action filter creation utils (elastic#62969) Refresh index pattern list before redirecting (elastic#63329) [APM]fixing custom link unit tests (elastic#64045) [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103) [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033) [Maps] Map settings: min and max zoom (elastic#63714) [kbn-storybook] Use raw loader for text files (elastic#64108) [EPM] /packages/{package} endpoint to support upgrades (elastic#63629) [SIEM] New Platform Saved Objects Registration (elastic#64029) [Endpoint] Hook to handle events needing navigation via Router (elastic#63863) Fixed small issue in clone functionality (elastic#64085) [Endpoint]EMT-146: use ingest agent for status info (elastic#63921) [SIEM] Server NP Followup (elastic#64010) Register uiSettings on New Platform (elastic#64015) [Reporting] Integration polling config with client code (elastic#63754) [Docs]7.7 SIEM doc updates (elastic#63951) [SIEM] [Cases] Tags suggestions (elastic#63878) Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027) [DOCS] Add file size setting for Data Visualizer (elastic#64006) ...
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes hard-coded values for reporting and replaces them with configurable settings.
xpack.reporting.poll.jobCompletionNotifier.intervalxpack.reporting.poll.jobCompletionNotifier.intervalErrorMultiplierxpack.reporting.poll.jobsRefresh.intervalxpack.reporting.poll.jobsRefresh.intervalErrorMultiplierAlso, some imports are cleaned up, as I ran the organize imports VS Code command over some of the files.