Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor action filter creation utils #62969

Merged
merged 10 commits into from
Apr 22, 2020
Merged

refactor action filter creation utils #62969

merged 10 commits into from
Apr 22, 2020

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Apr 8, 2020 •
edited
Loading

Summary

cleans up filter generation from action context

resolves #62936

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ppisljar ppisljar requested a review from a team April 8, 2020 16:06
@ppisljar ppisljar requested a review from a team as a code owner April 8, 2020 16:06
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Apr 8, 2020
@ppisljar ppisljar added release_note:skip Skip the PR/issue when compiling release notes Team:AppArch v7.8.0 v8.0.0 labels Apr 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich mentioned this pull request Apr 9, 2020
Closed
47 tasks
@ppisljar ppisljar force-pushed the cleanup/visevents branch from 6e77cfb to 4d57fcc Compare April 14, 2020 07:22
@mbondyra
Copy link
Contributor

@ppisljar I tried to test it locally but unfortunately for vertical bar vis for date histogram it doesn't work. It produces this bug in the console:
image

Example of not-working:
image

@Dosant
Copy link
Contributor

Dosant commented Apr 16, 2020

@mbondyra, could you re-review please. This should fix the issue: bc6d22f

@Dosant Dosant mentioned this pull request Apr 16, 2020
Merged
7 tasks
@Dosant
Copy link
Contributor

Dosant commented Apr 20, 2020

@elasticmachine merge upstream

@Dosant Dosant self-requested a review April 20, 2020 09:48
@ppisljar ppisljar force-pushed the cleanup/visevents branch from 9197e9e to 6c223c3 Compare April 21, 2020 12:11
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Dosant
Dosant approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in chrome and tried to use in drilldown branch.

mbondyra
mbondyra approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, tested on Chrome locally 👌 Thank you for taking care of it!

@ppisljar ppisljar merged commit 222fdc5 into elastic:master Apr 22, 2020
@ppisljar ppisljar mentioned this pull request Apr 22, 2020
Merged
ppisljar added a commit to ppisljar/kibana that referenced this pull request Apr 22, 2020
@ppisljar
refactor action filter creation utils (elastic#62969)
a4de954
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 22, 2020
@gmmorris
Merge branch 'master' into alerting/no-explicit-any
02077cc 
* master: (29 commits)
  [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611)
  refactor action filter creation utils (elastic#62969)
  Refresh index pattern list before redirecting (elastic#63329)
  [APM]fixing custom link unit tests (elastic#64045)
  [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103)
  [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033)
  [Maps] Map settings: min and max zoom (elastic#63714)
  [kbn-storybook] Use raw loader for text files (elastic#64108)
  [EPM] /packages/{package} endpoint to support upgrades (elastic#63629)
  [SIEM] New Platform Saved Objects Registration (elastic#64029)
  [Endpoint] Hook to handle events needing navigation via Router (elastic#63863)
  Fixed small issue in clone functionality (elastic#64085)
  [Endpoint]EMT-146: use ingest agent for status info (elastic#63921)
  [SIEM] Server NP Followup (elastic#64010)
  Register uiSettings on New Platform (elastic#64015)
  [Reporting] Integration polling config with client code (elastic#63754)
  [Docs]7.7 SIEM doc updates (elastic#63951)
  [SIEM] [Cases] Tags suggestions (elastic#63878)
  Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027)
  [DOCS] Add file size setting for Data Visualizer (elastic#64006)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 22, 2020
@gmmorris
Merge branch 'task-manager/cancel-logging' of github.com:gmmorris/kib…
c3b9f64 
…ana into task-manager/cancel-logging

* 'task-manager/cancel-logging' of github.com:gmmorris/kibana: (28 commits)
  [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611)
  refactor action filter creation utils (elastic#62969)
  Refresh index pattern list before redirecting (elastic#63329)
  [APM]fixing custom link unit tests (elastic#64045)
  [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103)
  [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033)
  [Maps] Map settings: min and max zoom (elastic#63714)
  [kbn-storybook] Use raw loader for text files (elastic#64108)
  [EPM] /packages/{package} endpoint to support upgrades (elastic#63629)
  [SIEM] New Platform Saved Objects Registration (elastic#64029)
  [Endpoint] Hook to handle events needing navigation via Router (elastic#63863)
  Fixed small issue in clone functionality (elastic#64085)
  [Endpoint]EMT-146: use ingest agent for status info (elastic#63921)
  [SIEM] Server NP Followup (elastic#64010)
  Register uiSettings on New Platform (elastic#64015)
  [Reporting] Integration polling config with client code (elastic#63754)
  [Docs]7.7 SIEM doc updates (elastic#63951)
  [SIEM] [Cases] Tags suggestions (elastic#63878)
  Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027)
  [DOCS] Add file size setting for Data Visualizer (elastic#64006)
  ...
ppisljar added a commit that referenced this pull request Apr 23, 2020
@ppisljar
refactor action filter creation utils (#62969) (#64143)
f8563f8
@streamich streamich mentioned this pull request Apr 30, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify context needed for SELECT_RANGE_TRIGGER action
5 participants
@ppisljar @elasticmachine @mbondyra @Dosant @kibanamachine