Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Fixed bug with no possibility to edit the index name after adding #64033

Merged
merged 6 commits into from
Apr 22, 2020
Merged

[Alerting] Fixed bug with no possibility to edit the index name after adding #64033

merged 6 commits into from
Apr 22, 2020

Conversation

YulNaumenko
Copy link
Contributor

Resolve #63701, #63828

@YulNaumenko YulNaumenko added release_note:fix Feature:Alerting v8.0.0 Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 v7.7.1 labels Apr 21, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner April 21, 2020 01:30
@YulNaumenko YulNaumenko self-assigned this Apr 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@YulNaumenko YulNaumenko linked an issue Apr 21, 2020 that may be closed by this pull request
Cannot remove index from connector #63828
Closed
pmuellr
pmuellr approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There's still something. slight funky about this - when you edit an existing index and press backspace, it deletes the whole entry, but the entry looks like a text field entry so I was expecting it to just delete the last character. Seems like we need the "box" around it like we do with the index threshold, and there should only be one "box". But that's a separate issue/PR, and I'm not sure it's even a problem anyway, since it's kind of a unique sort of field.

@YulNaumenko
fixed test
75bc9a9
@YulNaumenko
fixed selector
ec43002
@YulNaumenko
Merge remote-tracking branch 'upstream/master' into action-index-not-…
1ec3487 
…able-to-clean

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@mikecote mikecote self-requested a review April 21, 2020 19:33
mikecote
mikecote approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors.ts Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko merged commit 28313c4 into elastic:master Apr 22, 2020
@YulNaumenko YulNaumenko mentioned this pull request Apr 22, 2020
Merged
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Apr 22, 2020
@YulNaumenko
[Alerting] Fixed bug with no possibility to edit the index name after…
7e09365 
… adding (elastic#64033)

* Fixed bug with no possibility to edit the index name after adding

* fixed test

* fixed test

* fixed selector

* Move the testing to unit tests
@YulNaumenko YulNaumenko mentioned this pull request Apr 22, 2020
Closed
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 22, 2020
@gmmorris
Merge branch 'master' into alerting/no-explicit-any
02077cc 
* master: (29 commits)
  [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611)
  refactor action filter creation utils (elastic#62969)
  Refresh index pattern list before redirecting (elastic#63329)
  [APM]fixing custom link unit tests (elastic#64045)
  [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103)
  [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033)
  [Maps] Map settings: min and max zoom (elastic#63714)
  [kbn-storybook] Use raw loader for text files (elastic#64108)
  [EPM] /packages/{package} endpoint to support upgrades (elastic#63629)
  [SIEM] New Platform Saved Objects Registration (elastic#64029)
  [Endpoint] Hook to handle events needing navigation via Router (elastic#63863)
  Fixed small issue in clone functionality (elastic#64085)
  [Endpoint]EMT-146: use ingest agent for status info (elastic#63921)
  [SIEM] Server NP Followup (elastic#64010)
  Register uiSettings on New Platform (elastic#64015)
  [Reporting] Integration polling config with client code (elastic#63754)
  [Docs]7.7 SIEM doc updates (elastic#63951)
  [SIEM] [Cases] Tags suggestions (elastic#63878)
  Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027)
  [DOCS] Add file size setting for Data Visualizer (elastic#64006)
  ...
YulNaumenko added a commit that referenced this pull request Apr 22, 2020
@YulNaumenko
[Alerting] Fixed bug with no possibility to edit the index name after…
94a41ce 
… adding (#64033) (#64135)

* Fixed bug with no possibility to edit the index name after adding

* fixed test

* fixed test

* fixed selector

* Move the testing to unit tests
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 22, 2020
@gmmorris
Merge branch 'task-manager/cancel-logging' of github.com:gmmorris/kib…
c3b9f64 
…ana into task-manager/cancel-logging

* 'task-manager/cancel-logging' of github.com:gmmorris/kibana: (28 commits)
  [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611)
  refactor action filter creation utils (elastic#62969)
  Refresh index pattern list before redirecting (elastic#63329)
  [APM]fixing custom link unit tests (elastic#64045)
  [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103)
  [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033)
  [Maps] Map settings: min and max zoom (elastic#63714)
  [kbn-storybook] Use raw loader for text files (elastic#64108)
  [EPM] /packages/{package} endpoint to support upgrades (elastic#63629)
  [SIEM] New Platform Saved Objects Registration (elastic#64029)
  [Endpoint] Hook to handle events needing navigation via Router (elastic#63863)
  Fixed small issue in clone functionality (elastic#64085)
  [Endpoint]EMT-146: use ingest agent for status info (elastic#63921)
  [SIEM] Server NP Followup (elastic#64010)
  Register uiSettings on New Platform (elastic#64015)
  [Reporting] Integration polling config with client code (elastic#63754)
  [Docs]7.7 SIEM doc updates (elastic#63951)
  [SIEM] [Cases] Tags suggestions (elastic#63878)
  Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027)
  [DOCS] Add file size setting for Data Visualizer (elastic#64006)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 24, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

14 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request May 14, 2020
@YulNaumenko
[Alerting] Fixed bug with no possibility to edit the index name after…
ba88ebb 
… adding (elastic#64033)

* Fixed bug with no possibility to edit the index name after adding

* fixed test

* fixed test

* fixed selector

* Move the testing to unit tests
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request May 14, 2020
@YulNaumenko
[Alerting] Fixed bug with no possibility to edit the index name after…
e6efe39 
… adding (elastic#64033)

* Fixed bug with no possibility to edit the index name after adding

* fixed test

* fixed test

* fixed selector

* Move the testing to unit tests
@YulNaumenko YulNaumenko mentioned this pull request May 14, 2020
Merged
YulNaumenko added a commit that referenced this pull request May 14, 2020
@YulNaumenko
[Alerting] Fixed bug with no possibility to edit the index name after…
51383c8 
… adding (#64033) (#66598)

* Fixed bug with no possibility to edit the index name after adding

* fixed test

* fixed test

* fixed selector

* Move the testing to unit tests
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 14, 2020
@tylersmalley tylersmalley mentioned this pull request Jun 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

@pmuellr pmuellr pmuellr approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Actions Feature:Alerting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.1 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@YulNaumenko @elasticmachine @kibanamachine @pmuellr @mikecote