Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Searchprofiler] Spacing between rendered shards #60238

Merged
merged 2 commits into from
Mar 16, 2020

Conversation

jloleysens
Copy link
Contributor

Summary

Fix #57560

How to test

Create an index with more than one shard using the Console snippet below

PUT /twitter
{
    "settings" : {
        "index" : {
            "number_of_shards" : 3, 
            "number_of_replicas" : 2 
        }
    }
}

Run the default query in Searchprofiler and check that the spacing issue is fixed.

Screenshots

Screenshot 2020-03-16 at 11 19 03

Checklist

Release note

In Searchprofiler we fixed a layout issue for an index that has multiple shards.

@jloleysens jloleysens added Feature:Dev Tools release_note:fix v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Search Profiler v7.7.0 v7.6.2 labels Mar 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. LGTM.

@jloleysens jloleysens merged commit 1f8e938 into elastic:master Mar 16, 2020
@jloleysens jloleysens deleted the searchprofiler/ui-bug branch March 16, 2020 13:38
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 16, 2020
* Added unique key and some spacing to rendered shards

* Give key to React.Fragment
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 16, 2020
* Added unique key and some spacing to rendered shards

* Give key to React.Fragment
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 16, 2020
* master: (40 commits)
  skips 'config_open.ts' files from linter check (elastic#60248)
  [Searchprofiler] Spacing between rendered shards (elastic#60238)
  Add UiSettings validation & Kibana default route redirection (elastic#59694)
  [SIEM][CASE] Change configuration button (elastic#60229)
  [Step 1][App Arch] Saved object migrations from kibana plugin to new platform  (elastic#59044)
  adds new test (elastic#60064)
  [Uptime] Index Status API to Rest (elastic#59657)
  [SIEM] Adds 'Closes and opens signals' Cypress test (elastic#59950)
  [NP] Graph migration (elastic#59409)
  [ML] Clone analytics job  (elastic#59791)
  Move VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER to ui_action… (elastic#60202)
  Handle improperly defined Watcher Logging Action text parameter. (elastic#60169)
  Move select range trigger to uiActions (elastic#60168)
  [SIEM][CASES] Configure cases: Final (elastic#59358)
  Closes elastic#59784. Sets xpack.apm.serviceMapEnabled default value true. (elastic#60153)
  [siem/cypress] update junit filename to be picked up by runbld (elastic#60156)
  OSS logic added to test environment  (elastic#60134)
  Move canvas setup into app mount (elastic#59926)
  enable triggers_actions_ui plugin by default (elastic#60137)
  Expose Elasticsearch from start and deprecate from setup (elastic#59886)
  ...
jloleysens added a commit that referenced this pull request Mar 16, 2020
* Added unique key and some spacing to rendered shards

* Give key to React.Fragment
jloleysens added a commit that referenced this pull request Mar 16, 2020
* Added unique key and some spacing to rendered shards

* Give key to React.Fragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dev Tools Feature:Search Profiler release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.6.2 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SearchProfiler] Sharded Index renders weirdly and with React errors
4 participants