Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate core api docs #59814

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Mar 10, 2020

This is a companion PR to #56955.

That PR changed how API docs are generated; as a result, the next time any core API would be changed, all of the core API docs would be renamed.

After speaking to @lizozom we concluded that we should submit a separate PR to regenerate all of these files. I also noticed a couple of outdated references to check_core_api_changes, in the prior PR that was renamed to check_published_api_changes, so I took this opportunity to update those references as well.

Several log messages and a CODEOWNERS entry did not get updated
when this script was renamed to "check_published_api_changes" in
Due to elastic#56955, the file name suffix for newly-generated core API
docs have changed from `-public` and `-server` to `-core-public`
and `-core-server`, respectively.
The next PR to make any core API changes would have had to
regenerate all of these docs.
@jportner jportner added chore release_note:skip Skip the PR/issue when compiling release notes labels Mar 10, 2020
@jportner jportner requested a review from a team as a code owner March 10, 2020 18:57
@jportner
Copy link
Contributor Author

Jenkins test this

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner merged commit a2c002d into elastic:master Mar 10, 2020
@jportner jportner deleted the regenerate-core-api-docs branch March 10, 2020 21:24
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 11, 2020
* master:
  [ML] Transforms: Use EuiInMemoryTable instead of custom typed table. (elastic#59782)
  Alerting/fix flaky instance test (elastic#58994)
  ci: disable all Mocha rules for tape tests (elastic#59798)
  Fix UX in alerting UI forms when errors occur (elastic#59444)
  [DOCS] Updated and added jump tables (elastic#59774)
  [DOCS] Moved rolled up index content (elastic#59372)
  Regenerate core api docs (elastic#59814)
  [Lens] remove react warnings (elastic#59574)
  The scripts/backport.js file isn't an executable (elastic#59800)
  [Alerting] add more alert properties to action parameter templating (elastic#59718)
  [Design] Branding changes in Elastic to focus more towards the Elastic brand (elastic#58160)
  [SIEM] Adds 'Create new rule' Cypress test (elastic#59790)
  Updating svgo -> css-tree -> mdn-data, all so we get mdn-data > 2.0 (elastic#58913)
  Use EUI test environment build with Jest (elastic#55877)
  update typescript version in all packages to avoid warnings (elastic#59787)
  [SIEM] [Case] Insert timeline into case textarea (elastic#59586)
  [ML] Functional tests - stabilize saved search tests (elastic#59652)
jportner added a commit that referenced this pull request Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported chore release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants