Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate docs from data plugin #56955

Merged
merged 18 commits into from
Mar 10, 2020
Merged

Generate docs from data plugin #56955

merged 18 commits into from
Mar 10, 2020

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Feb 6, 2020 •
edited
Loading

Summary

Generate API docs for data plugin, and include that in API checks on Jenkins.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom mentioned this pull request Feb 10, 2020
Closed
11 tasks
@lizozom lizozom closed this Feb 26, 2020
@lizozom lizozom force-pushed the newplatform/docs-test branch from a499906 to 457783e Compare February 26, 2020 15:30
@lizozom lizozom reopened this Feb 26, 2020
@lizozom lizozom force-pushed the newplatform/docs-test branch from 1c1a24f to 04121ce Compare March 1, 2020 12:42
@lizozom lizozom self-assigned this Mar 3, 2020
@lizozom
Copy link
Contributor Author

lizozom commented Mar 5, 2020

Opened bug in the ApiExtractor project
microsoft/rushstack#1765

@lizozom lizozom changed the title Newplatform/docs test Generate docs from data plugin Mar 8, 2020
@lizozom lizozom marked this pull request as ready for review March 8, 2020 13:36
@lizozom lizozom requested review from a team as code owners March 8, 2020 13:36
@lizozom lizozom added Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Mar 8, 2020
@lizozom lizozom requested a review from rudolf March 8, 2020 13:37
@lizozom lizozom mentioned this pull request Mar 8, 2020
Closed
8 tasks
@lizozom lizozom requested a review from Dosant March 8, 2020 15:07
ppisljar
ppisljar approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

rudolf
rudolf requested changes Mar 9, 2020
View reviewed changes
src/dev/run_check_core_api_changes.ts Outdated Show resolved Hide resolved
src/dev/run_check_core_api_changes.ts Show resolved Hide resolved
@lizozom lizozom requested a review from a team as a code owner March 9, 2020 17:54
@lizozom lizozom requested review from rudolf and joshdover March 9, 2020 21:01
tylersmalley
tylersmalley approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build task LGTM, but will defer to Platform since they own the API changes check.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

rudolf
rudolf approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@rudolf rudolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for Platform changes

@lizozom lizozom merged commit 28d0cf4 into elastic:master Mar 10, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 10, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
0363764 
* master: (22 commits)
  Generate docs from data plugin (elastic#56955)
  Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514)
  Harden creation of child processes (elastic#55697)
  [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475)
  [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553)
  chore: 🤖 hide Drilldowns in master (elastic#59698)
  [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175)
  Use HTTP request schemas to create types, use those types in the client (elastic#59340)
  [Maps] Support categorical styling for numbers and dates (elastic#57908)
  [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665)
  Fix slm_ui setting by changing camel case back to snake case. (elastic#59663)
  removes beta tag (elastic#59618)
  [DOCS] Removed spatial references (elastic#59595)
  fix outdated docs (elastic#58729)
  [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639)
  [ML] Refactoring anomaly detector job types (elastic#59556)
  [Upgrade Assistant] Better handling of closed indices (elastic#58890)
  additional visualizations plugin cleanup before moving to NP (elastic#59318)
  In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285)
  [Visualize] Remove global state in visualize (elastic#58352)
  ...
@lizozom lizozom mentioned this pull request Mar 10, 2020
Merged
lizozom pushed a commit to lizozom/kibana that referenced this pull request Mar 10, 2020
Generate docs from data plugin (elastic#56955)
b2fde2f 
* Add doc building for data plugin

* Added data server md file

* index file for suggestion component

* Clear out internal imports from public API

* Remove FunctionalComponent usage

* comment out working docs

* Added fixes following @octogonz feedback

* new docs

* Clean up

* Clean up 2

* fix jest

* rename docs script file

* update tasks

* tasks

* update docs
# Conflicts:
#	src/dev/run_check_published_api_changes.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 10, 2020
@gmmorris
Merge branch 'alerting/fix-flaky-instance-test' of github.com:gmmorri…
ea98883 
…s/kibana into alerting/fix-flaky-instance-test

* 'alerting/fix-flaky-instance-test' of github.com:gmmorris/kibana: (176 commits)
  Generate docs from data plugin (elastic#56955)
  Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514)
  Harden creation of child processes (elastic#55697)
  [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475)
  [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553)
  chore: 🤖 hide Drilldowns in master (elastic#59698)
  [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175)
  Use HTTP request schemas to create types, use those types in the client (elastic#59340)
  [Maps] Support categorical styling for numbers and dates (elastic#57908)
  [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665)
  Fix slm_ui setting by changing camel case back to snake case. (elastic#59663)
  removes beta tag (elastic#59618)
  [DOCS] Removed spatial references (elastic#59595)
  fix outdated docs (elastic#58729)
  [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639)
  [ML] Refactoring anomaly detector job types (elastic#59556)
  [Upgrade Assistant] Better handling of closed indices (elastic#58890)
  additional visualizations plugin cleanup before moving to NP (elastic#59318)
  In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285)
  [Visualize] Remove global state in visualize (elastic#58352)
  ...
lizozom pushed a commit that referenced this pull request Mar 10, 2020
Generate docs from data plugin (#56955) (#59729)
6956091 
* Add doc building for data plugin

* Added data server md file

* index file for suggestion component

* Clear out internal imports from public API

* Remove FunctionalComponent usage

* comment out working docs

* Added fixes following @octogonz feedback

* new docs

* Clean up

* Clean up 2

* fix jest

* rename docs script file

* update tasks

* tasks

* update docs
# Conflicts:
#	src/dev/run_check_published_api_changes.ts
jportner added a commit to jportner/kibana that referenced this pull request Mar 10, 2020
@jportner
Regenerate core API docs
b047315 
Due to elastic#56955, the file name suffix for newly-generated core API
docs have changed from `-public` and `-server` to `-core-public`
and `-core-server`, respectively.
The next PR to make any core API changes would have had to
regenerate all of these docs.
@jportner jportner mentioned this pull request Mar 10, 2020
Merged
@rudolf rudolf mentioned this pull request Mar 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@rudolf rudolf rudolf approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

@Dosant Dosant Awaiting requested review from Dosant

@joshdover joshdover Awaiting requested review from joshdover

Assignees

@lizozom lizozom

Labels
Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lizozom @elasticmachine @kibanamachine @tylersmalley @rudolf @joshdover @ppisljar @streamich