Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps][docs] add more details to Quantitative data driven styling docs #59553

Merged
merged 9 commits into from
Mar 9, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Mar 6, 2020

[skip-ci]

There have been some questions recently about how quantitative data driven styling fits data and why the gear icon was not showing up when using styling by a count metric. I have updated the docs to contain the answers to these questions

cc @melvynator

@nreese nreese added Team:Docs [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.7.0 v7.6.0 labels Mar 6, 2020
@nreese nreese requested review from nickpeihl and gchaps March 6, 2020 14:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese changed the title [Maps][docs] add more details to Quantitative data driven styling [Maps][docs] add more details to Quantitative data driven styling docs Mar 6, 2020
@nreese nreese added the release_note:skip Skip the PR/issue when compiling release notes label Mar 6, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for expanding the docs.

docs/maps/maps-aggregations.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style.asciidoc Outdated Show resolved Hide resolved
docs/maps/maps-aggregations.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style.asciidoc Outdated Show resolved Hide resolved
docs/maps/vector-style.asciidoc Show resolved Hide resolved
@nreese nreese requested a review from gchaps March 9, 2020 21:12
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nreese nreese merged commit 6395dac into elastic:master Mar 9, 2020
nreese added a commit to nreese/kibana that referenced this pull request Mar 9, 2020
elastic#59553)

* [Maps][docs] add more details to Quantitative data driven styling

* Update docs/maps/maps-aggregations.asciidoc

Co-Authored-By: Nick Peihl <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* review feedback

Co-authored-by: Nick Peihl <[email protected]>
Co-authored-by: gchaps <[email protected]>
nreese added a commit to nreese/kibana that referenced this pull request Mar 9, 2020
elastic#59553)

* [Maps][docs] add more details to Quantitative data driven styling

* Update docs/maps/maps-aggregations.asciidoc

Co-Authored-By: Nick Peihl <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* review feedback

Co-authored-by: Nick Peihl <[email protected]>
Co-authored-by: gchaps <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 10, 2020
* master: (22 commits)
  Generate docs from data plugin (elastic#56955)
  Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514)
  Harden creation of child processes (elastic#55697)
  [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475)
  [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553)
  chore: 🤖 hide Drilldowns in master (elastic#59698)
  [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175)
  Use HTTP request schemas to create types, use those types in the client (elastic#59340)
  [Maps] Support categorical styling for numbers and dates (elastic#57908)
  [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665)
  Fix slm_ui setting by changing camel case back to snake case. (elastic#59663)
  removes beta tag (elastic#59618)
  [DOCS] Removed spatial references (elastic#59595)
  fix outdated docs (elastic#58729)
  [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639)
  [ML] Refactoring anomaly detector job types (elastic#59556)
  [Upgrade Assistant] Better handling of closed indices (elastic#58890)
  additional visualizations plugin cleanup before moving to NP (elastic#59318)
  In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285)
  [Visualize] Remove global state in visualize (elastic#58352)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 10, 2020
…s/kibana into alerting/fix-flaky-instance-test

* 'alerting/fix-flaky-instance-test' of github.com:gmmorris/kibana: (176 commits)
  Generate docs from data plugin (elastic#56955)
  Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514)
  Harden creation of child processes (elastic#55697)
  [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475)
  [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553)
  chore: 🤖 hide Drilldowns in master (elastic#59698)
  [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175)
  Use HTTP request schemas to create types, use those types in the client (elastic#59340)
  [Maps] Support categorical styling for numbers and dates (elastic#57908)
  [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665)
  Fix slm_ui setting by changing camel case back to snake case. (elastic#59663)
  removes beta tag (elastic#59618)
  [DOCS] Removed spatial references (elastic#59595)
  fix outdated docs (elastic#58729)
  [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639)
  [ML] Refactoring anomaly detector job types (elastic#59556)
  [Upgrade Assistant] Better handling of closed indices (elastic#58890)
  additional visualizations plugin cleanup before moving to NP (elastic#59318)
  In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285)
  [Visualize] Remove global state in visualize (elastic#58352)
  ...
nreese added a commit that referenced this pull request Mar 10, 2020
#59553) (#59706)

* [Maps][docs] add more details to Quantitative data driven styling

* Update docs/maps/maps-aggregations.asciidoc

Co-Authored-By: Nick Peihl <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* review feedback

Co-authored-by: Nick Peihl <[email protected]>
Co-authored-by: gchaps <[email protected]>

Co-authored-by: Nick Peihl <[email protected]>
Co-authored-by: gchaps <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
nreese added a commit that referenced this pull request Mar 10, 2020
#59553) (#59705)

* [Maps][docs] add more details to Quantitative data driven styling

* Update docs/maps/maps-aggregations.asciidoc

Co-Authored-By: Nick Peihl <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <[email protected]>

* review feedback

Co-authored-by: Nick Peihl <[email protected]>
Co-authored-by: gchaps <[email protected]>

Co-authored-by: Nick Peihl <[email protected]>
Co-authored-by: gchaps <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants