Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests - stabilize saved search tests #59652

Merged
merged 5 commits into from
Mar 10, 2020
Merged

[ML] Functional tests - stabilize saved search tests #59652

merged 5 commits into from
Mar 10, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Mar 9, 2020

Summary

This PR stabilizes the saved search functional UI tests.

Fixes #59354

@pheyos pheyos self-assigned this Mar 9, 2020
@pheyos
Copy link
Member Author

pheyos commented Mar 9, 2020 •
edited
Loading

Reproducing the issue in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/229/ ...
Reproduced successfully (5 failures in 20 runs).

@pheyos
Copy link
Member Author

pheyos commented Mar 10, 2020 •
edited
Loading

Testing fix for flakiness in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/238/ ...
No failure in 40 runs.

@pheyos
Copy link
Member Author

pheyos commented Mar 10, 2020 •
edited
Loading

Testing again in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/239/ ...
No failure in 40 runs.

@pheyos
Copy link
Member Author

pheyos commented Mar 10, 2020 •
edited
Loading

Testing again in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/241/ ...
No failure in 40 runs.

@pheyos pheyos added :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.7.0 v8.0.0 labels Mar 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos pheyos marked this pull request as ready for review March 10, 2020 15:23
@pheyos pheyos requested a review from a team as a code owner March 10, 2020 15:23
walterra
walterra approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos
Copy link
Member Author

pheyos commented Mar 10, 2020

Flaky test runner summary: no failure in 120 runs with the current fix.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos pheyos merged commit 8bc051a into elastic:master Mar 10, 2020
@pheyos pheyos deleted the fix_saved_search_tests branch March 10, 2020 17:11
pheyos added a commit to pheyos/kibana that referenced this pull request Mar 10, 2020
@pheyos
[ML] Functional tests - stabilize saved search tests (elastic#59652)
cbf271e 
This PR stabilizes the saved search functional UI tests by adding a retry to navigateToApp('ml')
@pheyos pheyos mentioned this pull request Mar 10, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 11, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
ff30bf8 
* master:
  [ML] Transforms: Use EuiInMemoryTable instead of custom typed table. (elastic#59782)
  Alerting/fix flaky instance test (elastic#58994)
  ci: disable all Mocha rules for tape tests (elastic#59798)
  Fix UX in alerting UI forms when errors occur (elastic#59444)
  [DOCS] Updated and added jump tables (elastic#59774)
  [DOCS] Moved rolled up index content (elastic#59372)
  Regenerate core api docs (elastic#59814)
  [Lens] remove react warnings (elastic#59574)
  The scripts/backport.js file isn't an executable (elastic#59800)
  [Alerting] add more alert properties to action parameter templating (elastic#59718)
  [Design] Branding changes in Elastic to focus more towards the Elastic brand (elastic#58160)
  [SIEM] Adds 'Create new rule' Cypress test (elastic#59790)
  Updating svgo -> css-tree -> mdn-data, all so we get mdn-data > 2.0 (elastic#58913)
  Use EUI test environment build with Jest (elastic#55877)
  update typescript version in all packages to avoid warnings (elastic#59787)
  [SIEM] [Case] Insert timeline into case textarea (elastic#59586)
  [ML] Functional tests - stabilize saved search tests (elastic#59652)
pheyos added a commit that referenced this pull request Mar 11, 2020
@pheyos
[ML] Functional tests - stabilize saved search tests (#59652) (#59795)
a06f510 
This PR stabilizes the saved search functional UI tests by adding a retry to navigateToApp('ml')
This was referenced Mar 12, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra walterra approved these changes

@darnautov darnautov Awaiting requested review from darnautov

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@pheyos pheyos

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@pheyos @elasticmachine @kibanamachine @walterra @peteharverson