BUG - Fix broken link in Rollup Jobs (#58802) #58929
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
TinaHeiligers
added
release_note:skip
timroes
added
the
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
There was a problem hiding this comment.
@justinjunodev thanks for the contribution. Great work! I left one comment if you could address before merging. Thanks!
| @@ -9,7 +9,7 @@ let xPackBase = ''; | |||
|
|
|||
| export function setEsBaseAndXPackBase(elasticWebsiteUrl, docLinksVersion) { | |||
| esBase = `${elasticWebsiteUrl}guide/en/elasticsearch/reference/${docLinksVersion}`; | |||
| xPackBase = `${elasticWebsiteUrl}guide/en/x-pack/${docLinksVersion}`; | |||
| xPackBase = `${elasticWebsiteUrl}guide/en/elasticsearch/reference/${docLinksVersion}`; | |||
There was a problem hiding this comment.
Rather than changing the value of xPackBase, can you use esBase on L11 and delete the xpackBase variable if it's no longer being used?
There was a problem hiding this comment.
Sure can. I also saw this and was curious if that was the correct/better approach here. Nonetheless, I just pushed an updated branch with the requested changes. Happy Monday.
|
@elasticmachine merge upstream |
|
jenkins test this |
|
jenkins test this |
There was a problem hiding this comment.
This looks great! Tested locally. Thanks for addressing my feedback @justinjunodev. I pushed a commit to your branch to fix a minor lint error. Once the build is green, I will go ahead and merge and backport the PR. Nice work!
|
Thanks, @alisonelizabeth! Thanks for letting me contribute again. 🥳🥳🥳 |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Summary
When creating a new rollup job, I noticed that the the Schedule section contained a broken link for getting more information on CRON expressions. More details for this issue can be found [here],(#58802) along with suggestions from team members that I followed to the make appropriate changes.
For maintainers