Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Fix broken link in Rollup Jobs (#58802) #58929

Merged
merged 4 commits into from
Mar 3, 2020
Merged

BUG - Fix broken link in Rollup Jobs (#58802) #58929

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16b43ec
fix broken link in create rollup
justinjunodev Feb 28, 2020
f6be0fd
remove xpack reference
justinjunodev Mar 2, 2020
b95f3c8
Merge branch 'master' into BUG/fix-broken-link-in-rollup-jobs-58802
elasticmachine Mar 2, 2020
1f4536c
fix lint error
alisonelizabeth Mar 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/legacy/plugins/rollup/public/crud_app/services/documentation_links.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ let xPackBase = '';

export function setEsBaseAndXPackBase(elasticWebsiteUrl, docLinksVersion) {
esBase = `${elasticWebsiteUrl}guide/en/elasticsearch/reference/${docLinksVersion}`;
xPackBase = `${elasticWebsiteUrl}guide/en/x-pack/${docLinksVersion}`;
xPackBase = `${elasticWebsiteUrl}guide/en/elasticsearch/reference/${docLinksVersion}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than changing the value of xPackBase, can you use esBase on L11 and delete the xpackBase variable if it's no longer being used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure can. I also saw this and was curious if that was the correct/better approach here. Nonetheless, I just pushed an updated branch with the requested changes. Happy Monday.

}

export const getLogisticalDetailsUrl = () => `${esBase}/rollup-job-config.html#_logistical_details`;
Expand All @@ -21,4 +21,4 @@ export const getMetricsDetailsUrl = () => `${esBase}/rollup-job-config.html#roll

export const getDateHistogramAggregationUrl = () =>
`${esBase}/search-aggregations-bucket-datehistogram-aggregation.html`;
export const getCronUrl = () => `${xPackBase}/trigger-schedule.html#_cron_expressions`;
export const getCronUrl = () => `${xPackBase}/trigger-schedule.html#_cron_expressions`;