Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Link in Create Rollup Jobs #58802

Closed
justinjunodev opened this issue Feb 28, 2020 · 8 comments
Closed

Broken Link in Create Rollup Jobs #58802

justinjunodev opened this issue Feb 28, 2020 · 8 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rollups Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@justinjunodev
Copy link
Contributor

Kibana version: 7.6

Describe the bug: Broken Link

Steps to reproduce:

  1. Create a new rollup job in Kibana.
  2. In the Logistics Schedule Settings, select "create cron expression".
  3. Select "Learn more about cron expressions" under input field.

Expected behavior:
Current content is linking to this page, which is a broken 404. I believe it needs to go here?

Any additional context:
If someone can point me in the direction in regards to this component and/or links location, I'll happily replace it. I'd love to contribute to this project again. ♥️

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@gchaps
Copy link
Contributor

gchaps commented Feb 28, 2020

The broken link is in the Rollup Jobs UI.

broken_link

@gchaps gchaps removed the Team:Docs label Feb 28, 2020
@justinjunodev
Copy link
Contributor Author

Nice I'll take a look later today and see if I can't get this sorted. Can some on Elastic confirm that the link I provided above is the desired link?

@lcawl
Copy link
Contributor

lcawl commented Feb 28, 2020

It looks like the out-dated link was trying to get to the (discontinued) X-Pack Reference (e.g. https://www.elastic.co/guide/en/x-pack/current/trigger-schedule.html#_cron_expressions)

You're right that the new location of that content is in the Elasticsearch book (https://www.elastic.co/guide/en/elasticsearch/reference/current/trigger-schedule.html#_cron_expressions).

@alisonelizabeth
Copy link
Contributor

@justinjunodev thanks for offering to take this on! This is the line of code that will need to be updated: https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/rollup/public/crud_app/services/documentation_links.js#L24

lcawl added a commit to elastic/elasticsearch that referenced this issue Feb 28, 2020
Sections in this page are linked from Kibana UIs, so we should be explicit about the anchor IDs so they don't change and break links.

Related to elastic/kibana#58802
@gchaps
Copy link
Contributor

gchaps commented Feb 28, 2020

@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cjcenizal cjcenizal added the bug Fixes for quality problems that affect the customer experience label Jul 6, 2020
@cjcenizal
Copy link
Contributor

Fixed by #58929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rollups Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

7 participants