[ML] Transform: Support multi-line JSON notation in advanced editor #58015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
release_note:enhancement
:ml
v8.0.0
Feature:Transforms
|
Pinging @elastic/ml-ui (:ml) |
walterra
reviewed
Feb 19, 2020
...s/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx
Outdated
Show resolved
Hide resolved
| @@ -37,3 +37,5 @@ export { setDependencyCache } from '../../ml/public/application/util/dependency_ | |||
|
|
|||
| // @ts-ignore: could not find declaration file for module | |||
| export { KqlFilterBar } from '../../ml/public/application/components/kql_filter_bar'; | |||
|
|
|||
| export { useXJsonMode } from '../../../../plugins/watcher/public/application/sections/watch_edit/components/json_watch_edit/use_x_json_mode'; | |||
There was a problem hiding this comment.
i wonder if it’s worth making a copy of use_x_json_mode
deep including from other x-pack plugins isn’t recommended, plus watcher isn't long for this world as kibana alerts are on the horizon.
There was a problem hiding this comment.
I agree we should copy the file. The inner imports of that file are more obvious to reimport because they come from the es_ui_shared folder.
|
Noticed the following: Copy pasting multi-line examples with script works now, great!
I noticed though when clicking "Apply changes" we auto-enforce code formatting which then makes the multi-line scripts become single-line:
I liked the auto-formatting in earlier versions but I think that's not useful here anymore. Do you agree we should disable it? |
darnautov
force-pushed
the
ML-41870-advanced-editor-enhancements
branch
from
a78c952 to
031023a
Compare
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Feb 21, 2020
…lastic#58015) * [ML] use xJsonMode * [ML] remove commented code * [ML] move use_x_json_mode hook, disable json formatting * [ML] mocks for shared_imports * [ML] ts-ignore worker import
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 21, 2020
…_improve-advanced-settings-save * commit '02efb01c481f9f24d8d707f06dfc68b2fb805001': (43 commits) [Endpoint] Add a flyout to alert list. (elastic#57926) Make sure index pattern has fields before parsing (elastic#58242) Sanitize workpad before sending to API (elastic#57704) [ML] Transform: Support multi-line JSON notation in advanced editor (elastic#58015) [Endpoint] Refactor Management List Tests (elastic#58148) [kbn/optimizer] include bootstrap cache key in optimizer cache key (elastic#58176) Do not refresh color scale on each lookup (elastic#57792) Updating to @elastic/[email protected] (elastic#54662) Trigger context (elastic#57870) [ML] Transforms: Adds clone feature to transforms list. (elastic#57837) [ML] New Platform server shim: update fields service routes (elastic#58060) [Endpoint] EMT-184: change endpoints to metadata up and down the code base. (elastic#58038) document difference between log record formats (elastic#57798) Expose elasticsearch config schema (elastic#57655) [ui/agg_response/tabify] update types for search/expressions/build_tabular_inspector_data.ts (elastic#58130) [SIEM] Cleans Cypress tests code (elastic#58134) fix: 🐛 make dev server Storybook builds work again (elastic#58188) Prevent core savedObjects plugin from being overridden (elastic#58193) Expose serverBasePath on client-side (elastic#58070) Fix legend sizing on area charts (elastic#58083) ...
darnautov
added a commit
that referenced
this pull request
Feb 22, 2020
…itor (#58015) (#58239) * [ML] Transform: Support multi-line JSON notation in advanced editor (#58015) * [ML] use xJsonMode * [ML] remove commented code * [ML] move use_x_json_mode hook, disable json formatting * [ML] mocks for shared_imports * [ML] ts-ignore worker import * [ML] remove unused imports
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 24, 2020
…-out-of-legacy * 'master' of github.com:elastic/kibana: [SIEM] [Case] Enable case by default. Snake to camel on UI (elastic#57936) [File upload] Update remaining File Upload dependencies for NP migration (elastic#58128) Use EuiTokens for ES field types (elastic#57911) Added UI support for the default action group for Alert Type Model (elastic#57603) force savedObject API consumers to define SO type explicitly (elastic#58022) Update dependency @elastic/charts to ^17.1.1 (elastic#57634) [Endpoint] Add a flyout to alert list. (elastic#57926) Make sure index pattern has fields before parsing (elastic#58242) Sanitize workpad before sending to API (elastic#57704) [ML] Transform: Support multi-line JSON notation in advanced editor (elastic#58015) [Endpoint] Refactor Management List Tests (elastic#58148) [kbn/optimizer] include bootstrap cache key in optimizer cache key (elastic#58176) Do not refresh color scale on each lookup (elastic#57792) Updating to @elastic/[email protected] (elastic#54662) Trigger context (elastic#57870) [ML] Transforms: Adds clone feature to transforms list. (elastic#57837) [ML] New Platform server shim: update fields service routes (elastic#58060) [Endpoint] EMT-184: change endpoints to metadata up and down the code base. (elastic#58038)
3 tasks
walterra
added a commit
that referenced
this pull request
Mar 3, 2020
Fixes regression introduced by #58015 to correctly initialize the transform wizard advanced editor with the current configuration.
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Mar 3, 2020
Fixes regression introduced by elastic#58015 to correctly initialize the transform wizard advanced editor with the current configuration.
walterra
added a commit
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #41870. Provides
XJsonModetoEuiCodeEditorwhich allows indenting painless code wrapped with""".Checklist