Added UI support for the default action group for Alert Type Model #57603

YulNaumenko · 2020-02-13T17:52:33Z

Summary

Added UI support for the default action group for Alert Type Model

Checklist

Delete any items that are not applicable to this PR.

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-02-13T17:52:35Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

…efault_action_group_as_props # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

mikecote · 2020-02-18T20:11:11Z

x-pack/plugins/triggers_actions_ui/public/types.ts

@@ -95,6 +96,7 @@ export interface AlertTypeModel {
  validate: (alertParams: any) => ValidationResult;
  alertParamsExpression: React.FunctionComponent<any>;
  defaultActionMessage?: string;
+  defaultActionGroup?: string;


I'm thinking this would belong nicely next to actionGroups on the server side? here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/server/types.ts#L66. Then we return the defaultActionGroup with the /types API. Thoughts?

Good point. I will update the PR the way you proposed.

Make it optional? And then the same logic to return the first one, if not specified? Probably makes sense to do that, as long as we can do it in one place; we shouldn't repeat that default calculation on the client, if we can.

…efault_action_group_as_props # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

pmuellr

LGTM

… type functions

mikecote

Looking good! Just a few small comments from my side. I believe we should have documentation about this limitation of only 1 action group?

x-pack/plugins/alerting/server/alert_type_registry.ts

x-pack/plugins/triggers_actions_ui/public/application/sections/alert_add/alert_form.tsx

…stic.com> Feb 20, 2020 at 12:40 PM

phillipb

@YulNaumenko For clarity, do you think it'd be better to call it defaultActionGroupId? Since ActionGroup is a type, being explicit that this is the id might reduce confusion. This might be a nit, but wanted to at least bring it up.

YulNaumenko · 2020-02-20T21:07:32Z

Yeah, from the usage prospective it might be more clear. I will rename it.

mikecote

Changes LGTM, thanks for doing this! 🙏

…efault_action_group_as_props # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

phillipb

LGTM!

…efault_action_group_as_props # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

kibanamachine · 2020-02-21T21:34:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: cf6c35c

History

💔 Build #27753 failed 0e7f7b8
💚 Build #27482 succeeded 18f19d3
💚 Build #27407 succeeded 27718f8
💔 Build #26608 failed aab2e51

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…_improve-advanced-settings-save * commit '98aa1d2d4f974f72a9a5397b1b91f11509f6fb7a': [SIEM] [Case] Enable case by default. Snake to camel on UI (elastic#57936) [File upload] Update remaining File Upload dependencies for NP migration (elastic#58128) Use EuiTokens for ES field types (elastic#57911) Added UI support for the default action group for Alert Type Model (elastic#57603) force savedObject API consumers to define SO type explicitly (elastic#58022) Update dependency @elastic/charts to ^17.1.1 (elastic#57634)

kibanamachine · 2020-02-22T22:08:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 57603 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-02-23T22:18:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 57603 or prevent reminders by adding the backport:skip label.

…-out-of-legacy * 'master' of github.com:elastic/kibana: [SIEM] [Case] Enable case by default. Snake to camel on UI (elastic#57936) [File upload] Update remaining File Upload dependencies for NP migration (elastic#58128) Use EuiTokens for ES field types (elastic#57911) Added UI support for the default action group for Alert Type Model (elastic#57603) force savedObject API consumers to define SO type explicitly (elastic#58022) Update dependency @elastic/charts to ^17.1.1 (elastic#57634) [Endpoint] Add a flyout to alert list. (elastic#57926) Make sure index pattern has fields before parsing (elastic#58242) Sanitize workpad before sending to API (elastic#57704) [ML] Transform: Support multi-line JSON notation in advanced editor (elastic#58015) [Endpoint] Refactor Management List Tests (elastic#58148) [kbn/optimizer] include bootstrap cache key in optimizer cache key (elastic#58176) Do not refresh color scale on each lookup (elastic#57792) Updating to @elastic/[email protected] (elastic#54662) Trigger context (elastic#57870) [ML] Transforms: Adds clone feature to transforms list. (elastic#57837) [ML] New Platform server shim: update fields service routes (elastic#58060) [Endpoint] EMT-184: change endpoints to metadata up and down the code base. (elastic#58038)

kibanamachine · 2020-02-25T18:18:45Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 57603 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-02-26T18:28:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 57603 or prevent reminders by adding the backport:skip label.

Added UI support for the default action group for Alert Type Model

e0f1246

YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Feb 13, 2020

YulNaumenko self-assigned this Feb 13, 2020

YulNaumenko added 3 commits February 13, 2020 10:09

Fixed set default on alert type select

aab2e51

Fixed type check

27718f8

YulNaumenko requested a review from a team as a code owner February 18, 2020 17:31

mikecote reviewed Feb 18, 2020

View reviewed changes

YulNaumenko added 2 commits February 18, 2020 12:51

Moved setting of default alert type to the server api

0e7f7b8

YulNaumenko requested a review from mikecote February 19, 2020 22:13

pmuellr approved these changes Feb 19, 2020

View reviewed changes

YulNaumenko added 2 commits February 19, 2020 16:58

Added default value for actionGroups if it is empty in register alert…

5080364

… type functions

Fixed type check

7102798

mikecote reviewed Feb 20, 2020

View reviewed changes

Fixed due to comments aed89377b9 Yuliia Naumenko <yuliia.naumenko@ela…

753a652

…stic.com> Feb 20, 2020 at 12:40 PM

YulNaumenko requested a review from a team February 20, 2020 20:42

phillipb reviewed Feb 20, 2020

View reviewed changes

mikecote approved these changes Feb 20, 2020

View reviewed changes

YulNaumenko added 2 commits February 20, 2020 13:40

Renamed defaultActionGroup to defaultActionGroupId

e76ba21

phillipb approved these changes Feb 20, 2020

View reviewed changes

YulNaumenko added 2 commits February 21, 2020 09:25

Fixed failing tests

cf6c35c

YulNaumenko merged commit 1eb0176 into elastic:master Feb 21, 2020

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 22, 2020

YulNaumenko mentioned this pull request Feb 24, 2020

[7.x] Added UI support for the default action group for Alert Type Model (#57603) #58365

Merged

YulNaumenko added backported and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 24, 2020

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 25, 2020

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added UI support for the default action group for Alert Type Model #57603

Added UI support for the default action group for Alert Type Model #57603

YulNaumenko commented Feb 13, 2020 •

edited

Loading

elasticmachine commented Feb 13, 2020

mikecote Feb 18, 2020

YulNaumenko Feb 18, 2020

pmuellr Feb 19, 2020

pmuellr left a comment

mikecote left a comment

phillipb left a comment

YulNaumenko commented Feb 20, 2020 •

edited

Loading

mikecote left a comment

phillipb left a comment

kibanamachine commented Feb 21, 2020

kibanamachine commented Feb 22, 2020

kibanamachine commented Feb 23, 2020

kibanamachine commented Feb 25, 2020

kibanamachine commented Feb 26, 2020

Added UI support for the default action group for Alert Type Model #57603

Added UI support for the default action group for Alert Type Model #57603

Conversation

YulNaumenko commented Feb 13, 2020 • edited Loading

Summary

Checklist

elasticmachine commented Feb 13, 2020

mikecote Feb 18, 2020

Choose a reason for hiding this comment

YulNaumenko Feb 18, 2020

Choose a reason for hiding this comment

pmuellr Feb 19, 2020

Choose a reason for hiding this comment

pmuellr left a comment

Choose a reason for hiding this comment

mikecote left a comment

Choose a reason for hiding this comment

phillipb left a comment

Choose a reason for hiding this comment

YulNaumenko commented Feb 20, 2020 • edited Loading

mikecote left a comment

Choose a reason for hiding this comment

phillipb left a comment

Choose a reason for hiding this comment

kibanamachine commented Feb 21, 2020

💚 Build Succeeded

History

kibanamachine commented Feb 22, 2020

kibanamachine commented Feb 23, 2020

kibanamachine commented Feb 25, 2020

kibanamachine commented Feb 26, 2020

YulNaumenko commented Feb 13, 2020 •

edited

Loading

YulNaumenko commented Feb 20, 2020 •

edited

Loading