Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] [Case] Enable case by default. Snake to camel on UI #57936

Merged
merged 22 commits into from
Feb 22, 2020
Merged

[SIEM] [Case] Enable case by default. Snake to camel on UI #57936

merged 22 commits into from
Feb 22, 2020

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Feb 18, 2020 •
edited
Loading

Summary

Resolves #57861

This PR enables Case in the SIEM menu and removes the feature flag for the Case API plugin, enabling Case by default. The PR also changes the UI case references from snake_case to camelCase. I also added a couple of tests for AllCases and CaseView, starting to think about those.

Update 2/19 - added code to the update_case route to ensure no version conflicts or unnecessary updates

@stephmilovic stephmilovic added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 18, 2020
@stephmilovic stephmilovic self-assigned this Feb 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

angorayc
angorayc reviewed Feb 21, 2020
View reviewed changes
x-pack/plugins/case/server/routes/api/update_case.ts
@@ -5,9 +5,16 @@
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curious, would case have it's own entry with the same level as SIEM as well in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats the plan :)

angorayc
angorayc approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @stephmilovic for the refactoring, I just created a case successfully. Another suggestion from my side is that given that we haven't support the markdown, would we want to hide the hint about it under the description field :p

@stephmilovic
Copy link
Contributor Author

stephmilovic commented Feb 21, 2020 •
edited
Loading

Thank you @stephmilovic for the refactoring, I just created a case successfully. Another suggestion from my side is that given that we haven't support the markdown, would we want to hide the hint about it under the description field :p

@angorayc thanks for the review. I'm currently working on the comment field, so fixing up the bugs with the poor markdown I wrote for description. we will be supporting markdown for case. check out our design prototype: https://www.figma.com/proto/r1fCnIlDvCeaS4FNgTYFxc/In-Progress-Cases-MVP?node-id=41%3A345&viewport=-3680%2C1501%2C0.5&scaling=min-zoom

XavierM
XavierM reviewed Feb 21, 2020
View reviewed changes
x-pack/plugins/case/server/routes/api/types.ts Outdated
@@ -32,12 +32,14 @@ export interface CaseAttributes extends NewCaseType, SavedObjectAttributes {

export type FlattenedCaseSavedObject = CaseAttributes & {
case_id: string;
version?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should always have a version, is that correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its ? in the SavedObject type: https://github.com/elastic/kibana/blob/master/src/core/server/saved_objects/types.ts#L73

Copy link
Contributor

@XavierM XavierM Feb 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can default it to zero in our end so we do not have to deal with the undefined type.

XavierM
XavierM approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM 🎸
Rock n roll!!!

@stephmilovic stephmilovic merged commit 98aa1d2 into elastic:master Feb 22, 2020
@stephmilovic stephmilovic deleted the case-cleanups branch February 22, 2020 14:29
@stephmilovic stephmilovic mentioned this pull request Feb 22, 2020
Merged
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Feb 22, 2020
@stephmilovic
[SIEM] [Case] Enable case by default. Snake to camel on UI (elastic#5…
f0a1f5d 
…7936)
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stephmilovic added a commit that referenced this pull request Feb 22, 2020
@stephmilovic
[SIEM] [Case] Enable case by default. Snake to camel on UI (#57936) (#…
31bc411 
…58312)
mbondyra added a commit to mbondyra/kibana that referenced this pull request Feb 22, 2020
@mbondyra
Merge commit '98aa1d2d4f974f72a9a5397b1b91f11509f6fb7a' into IS-27405…
e5802f7 
…_improve-advanced-settings-save

* commit '98aa1d2d4f974f72a9a5397b1b91f11509f6fb7a':
  [SIEM] [Case] Enable case by default. Snake to camel on UI (elastic#57936)
  [File upload] Update remaining File Upload dependencies for NP migration (elastic#58128)
  Use EuiTokens for ES field types (elastic#57911)
  Added UI support for the default action group for Alert Type Model (elastic#57603)
  force savedObject API consumers to define SO type explicitly (elastic#58022)
  Update dependency @elastic/charts to ^17.1.1 (elastic#57634)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 24, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ua/chore/move…
73c6267 
…-out-of-legacy

* 'master' of github.com:elastic/kibana:
  [SIEM] [Case] Enable case by default. Snake to camel on UI (elastic#57936)
  [File upload] Update remaining File Upload dependencies for NP migration (elastic#58128)
  Use EuiTokens for ES field types (elastic#57911)
  Added UI support for the default action group for Alert Type Model (elastic#57603)
  force savedObject API consumers to define SO type explicitly (elastic#58022)
  Update dependency @elastic/charts to ^17.1.1 (elastic#57634)
  [Endpoint] Add a flyout to alert list. (elastic#57926)
  Make sure index pattern has fields before parsing (elastic#58242)
  Sanitize workpad before sending to API (elastic#57704)
  [ML] Transform: Support multi-line JSON notation in advanced editor (elastic#58015)
  [Endpoint] Refactor Management List Tests (elastic#58148)
  [kbn/optimizer] include bootstrap cache key in optimizer cache key (elastic#58176)
  Do not refresh color scale on each lookup (elastic#57792)
  Updating to @elastic/[email protected] (elastic#54662)
  Trigger context (elastic#57870)
  [ML] Transforms: Adds clone feature to transforms list. (elastic#57837)
  [ML] New Platform server shim: update fields service routes (elastic#58060)
  [Endpoint] EMT-184: change endpoints to metadata up and down the code base. (elastic#58038)
@stephmilovic stephmilovic mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

@angorayc angorayc angorayc approved these changes

Assignees

@stephmilovic stephmilovic

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SIEM] [Case] To dos
5 participants
@stephmilovic @elasticmachine @kibanamachine @XavierM @angorayc