[Lens] Pie and treemap charts #55477

wylieconlon · 2020-01-21T22:09:08Z

Screenshots for reference:

Chart switcher prevents you from switching to Treemap if there are too many layers:

Closes #38837

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-01-28T16:23:08Z

Pinging @elastic/kibana-app (Team:KibanaApp)

mbondyra · 2020-03-27T10:15:44Z

@elasticmachine merge upstream

mbondyra · 2020-03-27T11:36:01Z

x-pack/legacy/plugins/lens/public/pie_visualization/expression.tsx

+  }
+  const metricColumn = firstTable.columns.find(c => c.id === metric)!;
+  const percentFormatter =
+    metricColumn.formatHint && metricColumn.formatHint?.id === 'percent'


nit:

Suggested change

metricColumn.formatHint && metricColumn.formatHint?.id === 'percent'

metricColumn?.formatHint?.id === 'percent'

x-pack/legacy/plugins/lens/public/xy_visualization/to_expression.ts

x-pack/legacy/plugins/lens/public/xy_visualization/xy_suggestions.ts

x-pack/legacy/plugins/lens/public/pie_visualization/visualization.tsx

mbondyra

I left some feedback in private messages about functional behaviour, thanks for creating a todo list!

… into lens/pie

mbondyra · 2020-05-05T08:07:34Z

Tested and all works as expected! The only thing that could use a bit of improvement would be the looks of treemap. The lack of padding between labels and chart slices looks a bit 'unfinished' to me, but that's not a blocker for releasing :)

markov00 · 2020-05-05T09:23:07Z

Tested and all works as expected! The only thing that could use a bit of improvement would be the looks of treemap. The lack of padding between labels and chart slices looks a bit 'unfinished' to me, but that's not a blocker for releasing :)

We are going to release a fix for that padding today

AlonaNadler · 2020-05-05T16:28:48Z

Hey, really nice job!!!

Any idea why when doing average it only shows one area and on sum, it shows more sub-areas. does it make sense or is it a bug?

The suggestions with the pie chart work well. the pie suggestions seem to be instead of table suggestions. There is still more place in the suggestion to include the table. Any chance you can add the table as well?

something I noticed, not sure if it's only in this or not

wylieconlon · 2020-05-05T18:20:15Z

@AlonaNadler If there's data missing, it's probably because it has 0s: because they have 0 area, they are hidden. Table suggestions were removed in #64740, and it doesn't make sense to bring them back in this PR.

cchaos

Did some scans and played with the three different chart types. Pretty slick.

One small thing to follow up with, but should go in for 7.8, is to update the "Label position" options for Treemaps. As "Inside or outside" and "Inside only" don't change anything and will be confusing/seem buggy to users.

kibanamachine · 2020-05-05T19:58:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: cb13465

History

💚 Build #45376 succeeded acf291e
💚 Build #45324 succeeded 2247a44
💚 Build #45257 succeeded 0e931b4
💔 Build #44975 failed ffca91c
💔 Build #44960 failed 2c5c461

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [Lens] Add pie and treemap visualizations * Fix types * Update to new platform * Support 2-layer treemap and legends, dark mode * Significant restructuring of code * Upgrade to latest charts library * Commit yarn.lock * chore: update elastic-charts * fix types after merge master * Add settings panel and merge visualizations * Fix tests * build: upgrade @elastic/charts to 19.0.0 * refactor: onBrushEnd breaking changes * fix: missing onBrushEnd argument changes * More updates * Fix XY rendering issue when all dates are empty * Fix bugs and tests * Use shared services location * Fix bug in XY chart * fix: update ech to 19.1.1 * fix: lens onBrushEnd breaking changes * Change how pie/treemap settings work * [Design] Fix up settings panel * [Design] Update partition chart config styles * fix eslint * Fix legend issues in pie and XY, add some tests * update to 19.1.2 * Fix text color for treemap * Fix chart switch bug * Fix suggestions Co-authored-by: Marta Bondyra <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Marco Vettorello <[email protected]> Co-authored-by: cchaos <[email protected]>

* [Lens] Add pie and treemap visualizations * Fix types * Update to new platform * Support 2-layer treemap and legends, dark mode * Significant restructuring of code * Upgrade to latest charts library * Commit yarn.lock * chore: update elastic-charts * fix types after merge master * Add settings panel and merge visualizations * Fix tests * build: upgrade @elastic/charts to 19.0.0 * refactor: onBrushEnd breaking changes * fix: missing onBrushEnd argument changes * More updates * Fix XY rendering issue when all dates are empty * Fix bugs and tests * Use shared services location * Fix bug in XY chart * fix: update ech to 19.1.1 * fix: lens onBrushEnd breaking changes * Change how pie/treemap settings work * [Design] Fix up settings panel * [Design] Update partition chart config styles * fix eslint * Fix legend issues in pie and XY, add some tests * update to 19.1.2 * Fix text color for treemap * Fix chart switch bug * Fix suggestions Co-authored-by: Marta Bondyra <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Marco Vettorello <[email protected]> Co-authored-by: cchaos <[email protected]> Co-authored-by: Marta Bondyra <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Marco Vettorello <[email protected]> Co-authored-by: cchaos <[email protected]>

wylieconlon changed the title ~~[Lens] Pie/sunburst chart~~ [Lens] Donut/sunburst/treemap chart Jan 23, 2020

wylieconlon added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 28, 2020

This comment has been minimized.

Sign in to view

wylieconlon mentioned this pull request Feb 13, 2020

Partitioning visualizations - improvement ideas elastic/elastic-charts#518

Open

11 tasks

This comment has been minimized.

Sign in to view

mbondyra reviewed Mar 27, 2020

View reviewed changes

x-pack/legacy/plugins/lens/public/xy_visualization/to_expression.ts Outdated Show resolved Hide resolved

mbondyra reviewed Mar 27, 2020

View reviewed changes

x-pack/legacy/plugins/lens/public/xy_visualization/xy_suggestions.ts Outdated Show resolved Hide resolved

mbondyra reviewed Mar 27, 2020

View reviewed changes

x-pack/legacy/plugins/lens/public/pie_visualization/visualization.tsx Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

wylieconlon commented Mar 27, 2020

View reviewed changes

x-pack/legacy/plugins/lens/public/pie_visualization/visualization.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/lens/public/pie_visualization/visualization.tsx Outdated Show resolved Hide resolved

mbondyra requested changes Mar 27, 2020

View reviewed changes

wylieconlon mentioned this pull request Apr 2, 2020

[Lens] Change top values default from 3 to 5, with some exceptions #62386

Closed

This comment has been minimized.

Sign in to view

[Lens] Add pie and treemap visualizations

031685e

wylieconlon force-pushed the lens/pie branch from 2ee53be to 031685e Compare April 9, 2020 22:21

wylieconlon added 3 commits April 10, 2020 10:20

Fix types

0132aa0

Merge remote-tracking branch 'origin/master' into lens/pie

b79313e

Update to new platform

fefd257

markov00 and others added 6 commits May 4, 2020 23:13

update to 19.1.2

202310f

Merge remote-tracking branch 'markov00/2020_09_04-upgrade-ech-19-0-0'…

723efaf

… into lens/pie

Fix text color for treemap

f0fea4b

Fix chart switch bug

8c97d21

Merge remote-tracking branch 'origin/master' into lens/pie

2247a44

Merge remote-tracking branch 'origin/master' into lens/pie

acf291e

wylieconlon requested review from timroes, mbondyra and a team and removed request for a team May 5, 2020 03:28

mbondyra approved these changes May 5, 2020

View reviewed changes

Merge remote-tracking branch 'origin/master' into lens/pie

5150caa

Fix suggestions

cb13465

cchaos approved these changes May 5, 2020

View reviewed changes

wylieconlon merged commit e5d7bb6 into elastic:master May 5, 2020

wylieconlon mentioned this pull request May 5, 2020

[7.x] [Lens] Pie and treemap charts (#55477) #65360

Merged

wylieconlon deleted the lens/pie branch May 5, 2020 20:01

wylieconlon mentioned this pull request May 29, 2020

Tree map in Visualize #11790

Closed

monfera mentioned this pull request Sep 13, 2021

Pie chart using filters instead of terms displays slices when there is no data #111743

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lens] Pie and treemap charts #55477

[Lens] Pie and treemap charts #55477

wylieconlon commented Jan 21, 2020 •

edited

Loading

elasticmachine commented Jan 28, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mbondyra commented Mar 27, 2020

mbondyra Mar 27, 2020

This comment has been minimized.

mbondyra left a comment

This comment has been minimized.

mbondyra commented May 5, 2020

markov00 commented May 5, 2020

AlonaNadler commented May 5, 2020

wylieconlon commented May 5, 2020 •

edited

Loading

cchaos left a comment

kibanamachine commented May 5, 2020

	metricColumn.formatHint && metricColumn.formatHint?.id === 'percent'
	metricColumn?.formatHint?.id === 'percent'

[Lens] Pie and treemap charts #55477

[Lens] Pie and treemap charts #55477

Conversation

wylieconlon commented Jan 21, 2020 • edited Loading

Checklist

elasticmachine commented Jan 28, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mbondyra commented Mar 27, 2020

mbondyra Mar 27, 2020

Choose a reason for hiding this comment

This comment has been minimized.

mbondyra left a comment

Choose a reason for hiding this comment

This comment has been minimized.

mbondyra commented May 5, 2020

markov00 commented May 5, 2020

AlonaNadler commented May 5, 2020

wylieconlon commented May 5, 2020 • edited Loading

cchaos left a comment

Choose a reason for hiding this comment

kibanamachine commented May 5, 2020

💚 Build Succeeded

History

wylieconlon commented Jan 21, 2020 •

edited

Loading

wylieconlon commented May 5, 2020 •

edited

Loading