[Lens] Hide some suggestions in preparation for pie charts #64740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylieconlon
added
release_note:skip
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
mbondyra
approved these changes
Apr 30, 2020
mbondyra
reviewed
Apr 30, 2020
| @@ -103,9 +103,16 @@ export interface TableSuggestion { | |||
| * * `unchanged` means the table is the same in the currently active configuration | |||
| * * `reduced` means the table is a reduced version of the currently active table (some columns dropped, but not all of them) | |||
| * * `extended` means the table is an extended version of the currently active table (added one or multiple additional columns) | |||
| * * `reorder` means the table columns have changed order, which change the data as well | |||
There was a problem hiding this comment.
out of curiosity, this is not possible yet in current lens?
There was a problem hiding this comment.
Yeah we were calling these "extended" tables, but that was before wanting to do special handling of these for the XY chart.
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
Apr 30, 2020
…4740) * [Lens] Hide some suggestions in preparation for pie charts * Suggest reordering the X and Break down by axis * More tweaks
wylieconlon
pushed a commit
that referenced
this pull request
Apr 30, 2020
…64909) * [Lens] Hide some suggestions in preparation for pie charts * Suggest reordering the X and Break down by axis * More tweaks Co-authored-by: Elastic Machine <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a reminder, suggestions are used in three different ways:
This change hides some of the suggestions from the bottom row, which will be replaced soon by pie chart suggestions.
Hides table suggestions from the bottom row
Hides some XY chart suggestions when looking at a different visualization
Hides XY chart suggestions that require removing a dimension
Improves the "reorder" suggestion when looking at 2 string fields in the XY chart
Checklist