Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mappings editor] Fix cannot set boolean value for "null_value" param #55015

Merged
merged 3 commits into from
Jan 17, 2020
Merged

[Mappings editor] Fix cannot set boolean value for "null_value" param #55015

merged 3 commits into from
Jan 17, 2020

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Jan 16, 2020 •
edited
Loading

This PR fixes the null_value that can not be set as boolean.

As null_value can actually be anything (string, number, boolean, object, array) (the geo_type https://www.elastic.co/guide/en/elasticsearch/reference/current/geo-point.html allows it all), I decided to remove the validation on our side and let ES do it.

There is an error that is thrown if we load this JSON

{
  "properties": {
    "my_field": {
      "type": "long",
      "null_value": []
    }
  }
}

And edit the field. The error (warning) is thrown in the browser console, but the error does not crash the UI.

Screen Shot 2020-01-16 at 15 38 55

Fix #54942

@sebelga sebelga added Feature:elasticsearch Feature:Mappings Editor Index mappings editor UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.6.0 v8.0.0 labels Jan 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

jloleysens
jloleysens approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for the check to be removed. Makes sense if null_type is constrained by type of mapping and in combination this would make validation checking much more involved for the Load JSON step. If this is ever more of an issue in future we can always revisit 👍

@sebelga
Copy link
Contributor Author

sebelga commented Jan 16, 2020

Thanks for the review @jloleysens !

@sebelga
Copy link
Contributor Author

sebelga commented Jan 16, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sebelga sebelga merged commit 92b5f78 into elastic:master Jan 17, 2020
@sebelga sebelga deleted the fix/cannot-set-boolean-value-for-boolean branch January 17, 2020 07:03
@sebelga sebelga mentioned this pull request Jan 17, 2020
Merged
sebelga added a commit to sebelga/kibana that referenced this pull request Jan 17, 2020
@sebelga
[Mappings editor] Fix cannot set boolean value for "null_value" param (…
82887a5 
…elastic#55015)
@sebelga sebelga mentioned this pull request Jan 17, 2020
Merged
sebelga added a commit that referenced this pull request Jan 17, 2020
@sebelga
[Mappings editor] Fix cannot set boolean value for "null_value" param (…
95b8923 
…#55015) (#55151)
sebelga added a commit that referenced this pull request Jan 17, 2020
@sebelga
[Mappings editor] Fix cannot set boolean value for "null_value" param (…
14292a1 
…#55015) (#55150)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 17, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into np/watcher/ou…
19ddfb8 
…t-of-legacy

* 'master' of github.com:elastic/kibana: (142 commits)
  [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069)
  Deprecate `chrome.navlinks.update` and add documentation (elastic#54893)
  [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045)
  [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864)
  [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015)
  [SIEM] Adds support for apm-* to the network map (elastic#54876)
  [Reporting] Define shims of legacy dependencies (elastic#54082)
  Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076)
  Upgraded EUI to 18.2.1 (elastic#55090)
  [Maps] Support styles on agg fields with _of_ in name (elastic#54965)
  Remove xpack_main requirement, it's no longer in use (elastic#55060)
  Fix Snapshots Policies Alignment Issue in IE11 (elastic#54866)
  first rule cuts (elastic#54990)
  [DOCS] Adds geocentroid note to coordinate map (elastic#54389)
  [Canvas] Fixes the Copy Post Url link (elastic#54831)
  Fixes bugs with full screen filters (elastic#54792)
  [ML] Fix decoding in the URL state  (elastic#54915)
  Remove redundant `x-pack/typings`. (elastic#55042)
  [SIEM][Detection Engine] Adds critical missing status route to prepackaged rules
  Generate legacy vars when rendering all applications (elastic#54768)
  ...

# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
@sebelga @jkelastic
[Mappings editor] Fix cannot set boolean value for "null_value" param (…
8fb26fa 
…elastic#55015)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 20, 2020
@gmmorris
Merge remote-tracking branch 'upstream/master'
edb0145 
* upstream/master: (83 commits)
  [Reporting] Fix map tiles not loading by using Chrome's Remote Protocol (elastic#55137)
  [Data Plugin] combine autocomplete provider and suggestions provider (elastic#54451)
  resolves elastic#53038 - remove references to specific license levels (elastic#53858)
  highlighting rules should still know about url parts when in sql state (elastic#55200)
  [Metric] convert mocha tests to jest (elastic#54054)
  [skip-ci] Update vector styling docs for 7.6 UI changes and new features (elastic#55087)
  Fix enable API to schedule task after alert is updated (elastic#55095)
  chore(NA): add 7.6 branch to the list of backport branches (elastic#54998)
  Convert tests to jest in vis_type_timeseries/public & common folders (elastic#55023)
  [ML] Accessibility fix for structural markup on table rows (elastic#55075)
  [Mappings editor] include/exclude fields only support custom options (elastic#54949)
  [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069)
  Deprecate `chrome.navlinks.update` and add documentation (elastic#54893)
  [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045)
  [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864)
  [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015)
  [SIEM] Adds support for apm-* to the network map (elastic#54876)
  [Reporting] Define shims of legacy dependencies (elastic#54082)
  Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076)
  Upgraded EUI to 18.2.1 (elastic#55090)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
Feature:elasticsearch Feature:Mappings Editor Index mappings editor UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mappings editor] Cannot set boolean value for boolean null_value parameter
4 participants
@sebelga @elasticmachine @kibanamachine @jloleysens