[Maps] Support styles on agg fields with _of_ in name #54965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
bug
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
reviewed
Jan 15, 2020
There was a problem hiding this comment.
This PR does not fix the root cause of the issue, that AbstractESAggSource.createField is broken if the field name contains _of_. The line below from https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/maps/public/layers/sources/es_agg_source.js#L74 needs to be modified to work if there are multiple _of_ in the fieldName. Maybe break the string apart with substring and first index of _of_ instead of using split?
const [aggType, docField] = fieldName.split(AGG_DELIMITER);
|
thanks. maybe we should just remove that method altogether? it's not used now anymore, since the vector_style uses getFieldByName. |
nreese
approved these changes
Jan 16, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jan 16, 2020
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jan 16, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 17, 2020
…t-of-legacy * 'master' of github.com:elastic/kibana: (142 commits) [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069) Deprecate `chrome.navlinks.update` and add documentation (elastic#54893) [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045) [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864) [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015) [SIEM] Adds support for apm-* to the network map (elastic#54876) [Reporting] Define shims of legacy dependencies (elastic#54082) Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076) Upgraded EUI to 18.2.1 (elastic#55090) [Maps] Support styles on agg fields with _of_ in name (elastic#54965) Remove xpack_main requirement, it's no longer in use (elastic#55060) Fix Snapshots Policies Alignment Issue in IE11 (elastic#54866) first rule cuts (elastic#54990) [DOCS] Adds geocentroid note to coordinate map (elastic#54389) [Canvas] Fixes the Copy Post Url link (elastic#54831) Fixes bugs with full screen filters (elastic#54792) [ML] Fix decoding in the URL state (elastic#54915) Remove redundant `x-pack/typings`. (elastic#55042) [SIEM][Detection Engine] Adds critical missing status route to prepackaged rules Generate legacy vars when rendering all applications (elastic#54768) ... # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
thomasneirynck
added a commit
that referenced
this pull request
Jan 17, 2020
thomasneirynck
added a commit
that referenced
this pull request
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the same fix as #51687
To reproduce:
Introduces
VectorSource#getFieldByNameto return a field-instance. In the case of agg-fields, it just returns an existing one (since they are passed in in the constructor).The only difference is thatESAggSource#createFieldcontinues to support returning a new object. I think this helps for consistency with all the source #createField implementations. (e.g. no other VectorSource enforces thatcreateFieldcan only create fields that are "known". imho AggSource shouldn't either.It removes the unused createField-method from the agg-source.