[Reporting] Fix map tiles not loading by using Chrome's Remote Protocol #55137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelgriffith
changed the title
|
@elasticmachine merge upstream |
tsullivan
reviewed
Jan 17, 2020
| // puppeteer's API will render map tiles as blanks :/ | ||
| client.on('Fetch.requestPaused', (interceptedRequest: InterceptedRequest) => { | ||
| const requestId = interceptedRequest.requestId; | ||
| const interceptedUrl = interceptedRequest.request.url; |
There was a problem hiding this comment.
how about:
const { requestId, request: { url: interceptedUrl } } = interceptedRequest;
tsullivan
approved these changes
Jan 17, 2020
|
Tested the changes using the Sample Data flights dashboard and it's looking great! |
|
Exported PNG of the Suricata Events dashboard is looking good!
|
added 3 commits
January 17, 2020 10:07
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Jan 17, 2020
Merged
joelgriffith
pushed a commit
that referenced
this pull request
Jan 18, 2020
…Protocol (#55137) (#55235) * [Reporting] Fix map tiles not loading by using Chrome's Remote Protocol (#55137) * WIP Fixing map tiles and such * Small comment and importing map from dolash * Better destructuring and comments Co-authored-by: Elastic Machine <[email protected]> * Fixing type woes in reportin' * Fixing dupe export Co-authored-by: Elastic Machine <[email protected]>
joelgriffith
pushed a commit
that referenced
this pull request
Jan 18, 2020
…ol (#55137) (#55240) * WIP Fixing map tiles and such * Small comment and importing map from dolash * Better destructuring and comments Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 20, 2020
* upstream/master: (83 commits) [Reporting] Fix map tiles not loading by using Chrome's Remote Protocol (elastic#55137) [Data Plugin] combine autocomplete provider and suggestions provider (elastic#54451) resolves elastic#53038 - remove references to specific license levels (elastic#53858) highlighting rules should still know about url parts when in sql state (elastic#55200) [Metric] convert mocha tests to jest (elastic#54054) [skip-ci] Update vector styling docs for 7.6 UI changes and new features (elastic#55087) Fix enable API to schedule task after alert is updated (elastic#55095) chore(NA): add 7.6 branch to the list of backport branches (elastic#54998) Convert tests to jest in vis_type_timeseries/public & common folders (elastic#55023) [ML] Accessibility fix for structural markup on table rows (elastic#55075) [Mappings editor] include/exclude fields only support custom options (elastic#54949) [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069) Deprecate `chrome.navlinks.update` and add documentation (elastic#54893) [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045) [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864) [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015) [SIEM] Adds support for apm-* to the network map (elastic#54876) [Reporting] Define shims of legacy dependencies (elastic#54082) Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076) Upgraded EUI to 18.2.1 (elastic#55090) ...
This was referenced Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates our request interception/monkeying to use Chrome's Devtool's Protocol. Benefit here is speed, but namely the fact that it allows us to load our map tiles(!!!!). I'll past the link to the issues here in a sec.
Fixes: