Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexicographically sort location tags #54832

Merged
merged 3 commits into from
Jan 14, 2020

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Jan 14, 2020

Summary

Sort location tags lexicographically, fixes skipped test by providing a stable, non-time-based sort order

@andrewvc andrewvc added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jan 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@andrewvc andrewvc added release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Jan 14, 2020
@andrewvc andrewvc self-assigned this Jan 14, 2020
@andrewvc andrewvc requested a review from justinkambic January 14, 2020 22:13
@andrewvc andrewvc changed the title Lexico sort location tags Lexicographically sort location tags Jan 14, 2020
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM WFG
Tested this locally and saw my locations alphabetized

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@andrewvc andrewvc merged commit 6cac02e into elastic:master Jan 14, 2020
@andrewvc andrewvc deleted the lexico-sort-location-tags branch January 14, 2020 23:29
andrewvc added a commit to andrewvc/kibana that referenced this pull request Jan 15, 2020
Sort location tags lexicographically, fixes skipped test by providing a stable, non-time-based sort order
andrewvc added a commit that referenced this pull request Jan 15, 2020
* Lexicographically sort location tags (#54832)

Sort location tags lexicographically, fixes skipped test by providing a stable, non-time-based sort order

* Update ping list snapshot
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 15, 2020
* upstream/master: (72 commits)
  [ML] Calculate model memory limit API integration tests (elastic#54557)
  Skip flakey index template component integration tests. (elastic#54878)
  Add label and icon to nested fields in the doc table (elastic#54199)
  Reverse dependency of home plugin and apm/ml/cloud (elastic#52883)
  [SIEM][Detection Engine] Order JSON keys, fix scripts, update pre-packaged rules
  update invalid snapshot
  add readme note about alerting / manage_api_key cluster privilege (elastic#54639)
  [SIEM] New Overview Page (elastic#54783)
  [Uptime] Feature/refactor context initialization (elastic#54494)
  Upgrade EUI to v18.2.0 (elastic#54786)
  [SIEM] [Detection engine] from signals to timeline (elastic#54769)
  [Index Management] Add Mappings Editor to Index Template Wizard (elastic#47562)
  [SIEM][Detection Engine] Removes deprecated filter from mapping
  [Maps] Add categorical styling (elastic#54408)
  Add mapbox-gl-rtl-text library (elastic#54842)
  [SIEM][Detection Engine] Adds actions to Rule Details (elastic#54828)
  Lexicographically sort location tags (elastic#54832)
  [Maps] expand extent filter to tile boundaries (elastic#54276)
  [Maps] Use v7.6 Elastic Maps Service API (elastic#54399)
  [DOCS] Adds monitoring setting (elastic#54819)
  ...
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
Sort location tags lexicographically, fixes skipped test by providing a stable, non-time-based sort order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants