[7.x] Lexicographically sort location tags (#54832) (#54867)

* Lexicographically sort location tags (#54832) Sort location tags lexicographically, fixes skipped test by providing a stable, non-time-based sort order * Update ping list snapshot
elastic · Jan 15, 2020 · 7556436 · 7556436
1 parent 7fd3e10
commit 7556436
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 15 deletions.
diff --git a/...onents/functional/location_map/__tests__/__snapshots__/location_status_tags.test.tsx.snap b/...onents/functional/location_map/__tests__/__snapshots__/location_status_tags.test.tsx.snap
diff --git a/.../uptime/public/components/functional/location_map/__tests__/location_status_tags.test.tsx b/.../uptime/public/components/functional/location_map/__tests__/location_status_tags.test.tsx
@@ -11,7 +11,7 @@ import { MonitorLocation } from '../../../../../common/runtime_types/monitor';
 import { LocationStatusTags } from '../';
 
 // Failing: https://github.com/elastic/kibana/issues/54818
-describe.skip('LocationStatusTags component', () => {
+describe('LocationStatusTags component', () => {
   let monitorLocations: MonitorLocation[];
 
   it('renders when there are many location', () => {

diff --git a/.../legacy/plugins/uptime/public/components/functional/location_map/location_status_tags.tsx b/.../legacy/plugins/uptime/public/components/functional/location_map/location_status_tags.tsx
@@ -60,9 +60,9 @@ export const LocationStatusTags = ({ locations }: Props) => {
     }
   });
 
-  // Sort by recent timestamp
+  // Sort lexicographically by label
   upLocations.sort((a, b) => {
-    return a.timestamp < b.timestamp ? 1 : b.timestamp < a.timestamp ? -1 : 0;
+    return a.label > b.label ? 1 : b.label > a.label ? -1 : 0;
   });
 
   moment.locale('en', {

diff --git a/...me/public/components/functional/ping_list/__tests__/__snapshots__/ping_list.test.tsx.snap b/...me/public/components/functional/ping_list/__tests__/__snapshots__/ping_list.test.tsx.snap