-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] [Detection engine] from signals to timeline #54769
Merged
XavierM
merged 11 commits into
elastic:master
from
XavierM:detection-engine-view-timeline
Jan 15, 2020
Merged
[SIEM] [Detection engine] from signals to timeline #54769
XavierM
merged 11 commits into
elastic:master
from
XavierM:detection-engine-view-timeline
Jan 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine-view-timeline
… raw events in timeline
…ine-view-timeline
…ine-view-timeline
Pinging @elastic/siem (Team:SIEM) |
XavierM
changed the title
[SIEM] [Detection engine] form signals to timeline
[SIEM] [Detection engine] from signals to timeline
Jan 14, 2020
x-pack/legacy/plugins/siem/public/components/timeline/body/events/stateful_event.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/components/timeline/search_or_filter/pick_events.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/components/timeline/search_or_filter/pick_events.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/components/timeline/search_or_filter/pick_events.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals/actions.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals/actions.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals/actions.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals/actions.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals/default_config.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals/helpers.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals/helpers.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals/helpers.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals/index.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals/index.tsx
Show resolved
Hide resolved
.../plugins/siem/public/pages/detection_engine/components/signals/signals_utility_bar/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/all/columns.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/all/columns.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/all/helpers.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/server/graphql/scalar_to_any/resolvers.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals/actions.tsx
Outdated
Show resolved
Hide resolved
FrankHassanabad
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for all the work and making all the changes requested.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jan 15, 2020
* remove batch action on signals * fix callback dependency bug * open timeline in signals table + add a way to pick between signal and raw events in timeline * add status on all rules * fix i18n * review I * fix test
andrew-goldstein
pushed a commit
that referenced
this pull request
Jan 15, 2020
* remove batch action on signals * fix callback dependency bug * open timeline in signals table + add a way to pick between signal and raw events in timeline * add status on all rules * fix i18n * review I * fix test Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Garrett Spong <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 15, 2020
* upstream/master: (72 commits) [ML] Calculate model memory limit API integration tests (elastic#54557) Skip flakey index template component integration tests. (elastic#54878) Add label and icon to nested fields in the doc table (elastic#54199) Reverse dependency of home plugin and apm/ml/cloud (elastic#52883) [SIEM][Detection Engine] Order JSON keys, fix scripts, update pre-packaged rules update invalid snapshot add readme note about alerting / manage_api_key cluster privilege (elastic#54639) [SIEM] New Overview Page (elastic#54783) [Uptime] Feature/refactor context initialization (elastic#54494) Upgrade EUI to v18.2.0 (elastic#54786) [SIEM] [Detection engine] from signals to timeline (elastic#54769) [Index Management] Add Mappings Editor to Index Template Wizard (elastic#47562) [SIEM][Detection Engine] Removes deprecated filter from mapping [Maps] Add categorical styling (elastic#54408) Add mapbox-gl-rtl-text library (elastic#54842) [SIEM][Detection Engine] Adds actions to Rule Details (elastic#54828) Lexicographically sort location tags (elastic#54832) [Maps] expand extent filter to tile boundaries (elastic#54276) [Maps] Use v7.6 Elastic Maps Service API (elastic#54399) [DOCS] Adds monitoring setting (elastic#54819) ...
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
* remove batch action on signals * fix callback dependency bug * open timeline in signals table + add a way to pick between signal and raw events in timeline * add status on all rules * fix i18n * review I * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately