Update dependency @elastic/charts to v15.0.1 #50513

renovate · 2019-11-13T18:33:58Z

This PR contains the following updates:

Package	Type	Update	Change
@elastic/charts	dependencies	major	`^14.0.0` -> `^15.0.1`

Release Notes

elastic/elastic-charts

`v15.0.0`

Compare Source

Code Refactoring

series identifications throughout library (#419) (66a48ff)
use redux in favour of mobx (#281) (cd34716)

BREAKING CHANGES

GeometryId is now SeriesIdentifier. customSeriesColors prop on SeriesSpec which used to take a CustomSeriesColorsMap, now expects a CustomSeriesColors type. LegendItemListener now passes the SeriesIdentifier type as the first callback argument.
SpecId,AxisId, AnnotationId types are down-casted to a string type. The getSpecId, getAxisId and getAnnotationId methods still exist and but return just the same passed string until deprecated in a future version. The spec ids, previously id, axisId,annotationId etc are now aligned to use the same prop name: id. The chart rendering status data-ech-render-complete and data-ech-render-count is no more at the root level of the echChart div, but on its child element: echChartStatus. The Spec has two new private properties called chartType and specType.

`v14.2.0`

Compare Source

Code Refactoring

series identifications throughout library (#419) (66a48ff)
use redux in favour of mobx (#281) (cd34716)

BREAKING CHANGES

GeometryId is now SeriesIdentifier. customSeriesColors prop on SeriesSpec which used to take a CustomSeriesColorsMap, now expects a CustomSeriesColors type. LegendItemListener now passes the SeriesIdentifier type as the first callback argument.
SpecId,AxisId, AnnotationId types are down-casted to a string type. The getSpecId, getAxisId and getAnnotationId methods still exist and but return just the same passed string until deprecated in a future version. The spec ids, previously id, axisId,annotationId etc are now aligned to use the same prop name: id. The chart rendering status data-ech-render-complete and data-ech-render-count is no more at the root level of the echChart div, but on its child element: echChartStatus. The Spec has two new private properties called chartType and specType.

`v14.1.0`

Compare Source

Features

add PNG export (#451) (e844687), closes #82

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

Newsflash: Renovate has joined WhiteSource, and is now free for all use. Learn more or view updated terms and privacy policies.

elasticmachine · 2019-11-13T19:48:47Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 5ae4f8e

elasticmachine · 2019-11-22T20:55:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e643dbc

elasticmachine · 2019-11-25T16:38:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 075dbd2

spalger · 2019-11-25T18:24:10Z

@elasticmachine merge upstream

renovate · 2019-11-25T18:28:06Z

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

elasticmachine · 2019-11-25T19:46:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 9710365

elasticmachine · 2019-12-02T17:39:33Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 45dab2c

nickofthyme · 2019-12-02T23:18:49Z

@spalger I wanted to verify with you. I kept getting the following error when react hooks since we are currently using react as a dependency not a peerDependency in @elastic/charts. Hopefully, this is changed soon 👉elastic/elastic-charts#378

Uncaught Invariant Violation: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app

I was able to fix it by adding react to the yarn resolutions to force the version to match/use that of kibana but wanted to make sure this doesn't have any negative consequences that I'm not aware of, so long as all checks pass.

elasticmachine · 2019-12-03T00:40:27Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: a536b22

elasticmachine · 2019-12-03T04:12:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 3f7a661

elasticmachine · 2019-12-03T06:45:17Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: baf0d08

markov00

LGTM, the VRTs are slightly off because of a small change in the CanvasBBoxCalculator implementation added in the MobX -> Redux refactoring. I think we can approve all of them

test/visual_regression/tests/discover/chart_visualization.js

nickofthyme · 2019-12-03T15:23:06Z

@elastic/ml-ui & @elastic/logs-metrics-ui Could someone please review the elastic charts in your apps and make sure these changes don't cause a regression? Thanks!

peteharverson

Looking at the ML charts, has the behavior changed to disable hover events? We now see a circle for line charts, where before we intentionally have no hover effect:

and for bar charts, the color of the hovered over bar lightens slightly:

Is there any way to disable this?

nickofthyme · 2019-12-03T17:25:32Z

@markov00 have you noticed this with the redux changes? ☝️

markov00 · 2019-12-04T12:43:36Z

@markov00 have you noticed this with the redux changes? ☝️

No, I haven't. Let me check and see if I forgot something during the refactoring

markov00 · 2019-12-04T12:56:47Z

Ok, it's a regression. I opened an issue on our repo and I will fix that soon elastic/elastic-charts#478

elasticmachine · 2019-12-05T20:28:44Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 993b6f1cfa22c31174293ef84d7db3eccd1cf3fa

nickofthyme · 2019-12-05T20:31:13Z

@peteharverson I updated the library with a patch for the hover issue. Could you please take another look when you have time?

Thanks

elasticmachine · 2019-12-05T21:50:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 995575e

markov00

Waiting for elastic/elastic-charts#489 to be fixed to avoid the clipped rendering of the highlighter

markov00 · 2019-12-10T11:43:38Z

closing in favour of #52619

renovate bot added release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates v7.6.0 v8.0.0 labels Nov 13, 2019

renovate bot requested a review from markov00 November 13, 2019 18:33

renovate bot force-pushed the renovate/@elasticcharts branch from 5ae4f8e to e643dbc Compare November 22, 2019 19:36

renovate bot force-pushed the renovate/@elasticcharts branch from e643dbc to 075dbd2 Compare November 25, 2019 15:12

renovate bot changed the title ~~Update dependency @elastic/charts to ^14.1.0~~ Update dependency @elastic/charts to ^14.2.0 Nov 25, 2019

Update dependency @elastic/charts to v15

45dab2c

renovate bot force-pushed the renovate/@elasticcharts branch from 9710365 to 45dab2c Compare December 2, 2019 17:09

renovate bot changed the title ~~Update dependency @elastic/charts to ^14.2.0~~ Update dependency @elastic/charts to v15 Dec 2, 2019

nickofthyme added the renovate:major Renovate dependency update with major version updates label Dec 2, 2019

nickofthyme added 3 commits December 2, 2019 15:36

fix: id type changes with charts

ac9b755

fix: make changes to customSeriesColors

f7f9e8f

fix: elastic-charts update and react resolution

4ea2df3

renovate bot requested a review from a team December 2, 2019 23:12

renovate bot requested review from a team as code owners December 2, 2019 23:12

fix: update jest snapshots

a536b22

nickofthyme added 2 commits December 2, 2019 20:20

fix: update tests with breaking changes

2e110c2

fix: vrt chart css selector

3f7a661

fix: jest snapshots

b7d2251

nickofthyme changed the title ~~Update dependency @elastic/charts to v15~~ Update dependency @elastic/charts to v15.0.1 Dec 3, 2019

fix: x-pack jest snapshots

baf0d08

markov00 approved these changes Dec 3, 2019

View reviewed changes

test/visual_regression/tests/discover/chart_visualization.js Outdated Show resolved Hide resolved

peteharverson reviewed Dec 3, 2019

View reviewed changes

markov00 mentioned this pull request Dec 4, 2019

Highlighter shown with hidden tooltip elastic/elastic-charts#478

Closed

2 tasks

renovate bot force-pushed the renovate/@elasticcharts branch from baf0d08 to 993b6f1 Compare December 5, 2019 19:14

Update dependency @elastic/charts to v15.0.3

9a8b20f

nickofthyme force-pushed the renovate/@elasticcharts branch from 993b6f1 to 9a8b20f Compare December 5, 2019 20:20

Merge branch 'master' into renovate/@elasticcharts

995575e

markov00 requested review from peteharverson, angorayc and markov00 December 6, 2019 11:37

markov00 mentioned this pull request Dec 9, 2019

Highlighter clip path interference with multiple instances elastic/elastic-charts#489

Closed

2 tasks

markov00 requested changes Dec 9, 2019

View reviewed changes

markov00 mentioned this pull request Dec 10, 2019

Update dependency @elastic/charts to v16 #52619

Merged

4 tasks

markov00 closed this Dec 10, 2019

renovate bot deleted the renovate/@elasticcharts branch December 13, 2019 10:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependency @elastic/charts to v15.0.1 #50513

Update dependency @elastic/charts to v15.0.1 #50513

renovate bot commented Nov 13, 2019 •

edited by nickofthyme

Loading

elasticmachine commented Nov 13, 2019

elasticmachine commented Nov 22, 2019

elasticmachine commented Nov 25, 2019

spalger commented Nov 25, 2019

renovate bot commented Nov 25, 2019

elasticmachine commented Nov 25, 2019

elasticmachine commented Dec 2, 2019

nickofthyme commented Dec 2, 2019 •

edited

Loading

elasticmachine commented Dec 3, 2019

elasticmachine commented Dec 3, 2019

elasticmachine commented Dec 3, 2019

markov00 left a comment

nickofthyme commented Dec 3, 2019

peteharverson left a comment

nickofthyme commented Dec 3, 2019

markov00 commented Dec 4, 2019

markov00 commented Dec 4, 2019 •

edited

Loading

elasticmachine commented Dec 5, 2019

nickofthyme commented Dec 5, 2019

elasticmachine commented Dec 5, 2019

markov00 left a comment

markov00 commented Dec 10, 2019

Update dependency @elastic/charts to v15.0.1 #50513

Update dependency @elastic/charts to v15.0.1 #50513

Conversation

renovate bot commented Nov 13, 2019 • edited by nickofthyme Loading

Release Notes

v15.0.0

Code Refactoring

BREAKING CHANGES

v14.2.0

Code Refactoring

BREAKING CHANGES

v14.1.0

Features

Renovate configuration

elasticmachine commented Nov 13, 2019

💔 Build Failed

elasticmachine commented Nov 22, 2019

💚 Build Succeeded

elasticmachine commented Nov 25, 2019

💚 Build Succeeded

spalger commented Nov 25, 2019

renovate bot commented Nov 25, 2019

PR has been edited

elasticmachine commented Nov 25, 2019

💚 Build Succeeded

elasticmachine commented Dec 2, 2019

💔 Build Failed

nickofthyme commented Dec 2, 2019 • edited Loading

elasticmachine commented Dec 3, 2019

💔 Build Failed

elasticmachine commented Dec 3, 2019

💔 Build Failed

elasticmachine commented Dec 3, 2019

💚 Build Succeeded

markov00 left a comment

Choose a reason for hiding this comment

nickofthyme commented Dec 3, 2019

peteharverson left a comment

Choose a reason for hiding this comment

nickofthyme commented Dec 3, 2019

markov00 commented Dec 4, 2019

markov00 commented Dec 4, 2019 • edited Loading

elasticmachine commented Dec 5, 2019

💔 Build Failed

nickofthyme commented Dec 5, 2019

elasticmachine commented Dec 5, 2019

💚 Build Succeeded

markov00 left a comment

Choose a reason for hiding this comment

markov00 commented Dec 10, 2019

renovate bot commented Nov 13, 2019 •

edited by nickofthyme

Loading

`v15.0.0`

`v14.2.0`

`v14.1.0`

nickofthyme commented Dec 2, 2019 •

edited

Loading

markov00 commented Dec 4, 2019 •

edited

Loading