Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighter shown with hidden tooltip #478

Closed
2 tasks done
markov00 opened this issue Dec 4, 2019 · 1 comment · Fixed by #482 or elastic/kibana#52619
Closed
2 tasks done

Highlighter shown with hidden tooltip #478

markov00 opened this issue Dec 4, 2019 · 1 comment · Fixed by #482 or elastic/kibana#52619
Assignees
@markov00
Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart regression released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Dec 4, 2019

Describe the bug
If you specify the tooltip type as None, the highlighter on the line and bars still shown the highlighted elements.

To Reproduce
Steps to reproduce the behavior:

  1. Paste this snippet on the playground:
<Chart>
  <Settings tooltip={{ type: TooltipType.None }} />
  <LineSeries
    id="lines"
    xAccessor={0}
    yAccessors={[1]}
    data={KIBANA_METRICS.metrics.kibana_os_load[0].data}
  />
</Chart>
  1. Mouse over one point
  2. An highlight circle appear on every point when mouse over

Expected behavior
If tooltip type None the highlighter should not be rendered

Screenshots
70072008-18c22d80-15ee-11ea-87dc-7ad218d26601
70072071-342d3880-15ee-11ea-8445-59d6dffc000c

Version (please complete the following information):

  • Browser: all
  • Elastic Charts: 15.0.1

Additional context
regression found during Kibana dependency update elastic/kibana#50513
Catch during manual testing

Errors in browser console
n/a

Kibana Cross Issues
elastic/kibana#50513

Checklist

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@markov00 markov00 added bug Something isn't working kibana cross issue Has a Kibana issue counterpart regression labels Dec 4, 2019
@markov00 markov00 mentioned this issue Dec 4, 2019
Closed
1 task
@markov00 markov00 self-assigned this Dec 4, 2019
markov00 added a commit to markov00/elastic-charts that referenced this issue Dec 5, 2019
@markov00
fix(highlighter): hide when tooltip type is None
10237d1 
If the tooltip type is hidden (TooltipType.None) then the tooltip should not be shown. This add the
check on the selector and includes also a smoke test.

fix elastic#478
@markov00 markov00 mentioned this issue Dec 5, 2019
Merged
2 tasks
markov00 added a commit that referenced this issue Dec 5, 2019
@markov00
fix(highlighter): hide it when tooltip type is None (#482)
6032c29 
If the tooltip type is hidden (TooltipType.None) then the tooltip should not be shown. This add the check on the selector and includes also a smoke test.

fix #478, fix #479
markov00 pushed a commit that referenced this issue Dec 5, 2019
@semantic-release-bot
chore(release): 15.0.3 [skip ci]
26c8d8b 
## [15.0.3](v15.0.2...v15.0.3) (2019-12-05)

### Bug Fixes

* **highlighter:** hide it when tooltip type is None ([#482](#482)) ([6032c29](6032c29)), closes [#478](#478) [#479](#479)
@markov00
Copy link
Member Author

markov00 commented Dec 5, 2019

🎉 This issue has been resolved in version 15.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Dec 5, 2019
@markov00 markov00 mentioned this issue Dec 10, 2019
Merged
4 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 15.0.3 [skip ci]
2049278 
## [15.0.3](elastic/elastic-charts@v15.0.2...v15.0.3) (2019-12-05)

### Bug Fixes

* **highlighter:** hide it when tooltip type is None ([opensearch-project#482](elastic/elastic-charts#482)) ([f6de794](elastic/elastic-charts@f6de794)), closes [opensearch-project#478](elastic/elastic-charts#478) [opensearch-project#479](elastic/elastic-charts#479)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart regression released Issue released publicly
Projects
None yet
Milestone
No milestone
1 participant
@markov00