Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighter clip path interference with multiple instances #489

Closed
2 tasks done
markov00 opened this issue Dec 9, 2019 · 1 comment · Fixed by #490 or elastic/kibana#52619
Closed
2 tasks done

Highlighter clip path interference with multiple instances #489

markov00 opened this issue Dec 9, 2019 · 1 comment · Fixed by #490 or elastic/kibana#52619
Assignees
@markov00
Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Dec 9, 2019

Describe the bug
The clip path used for the highlighter is generated using an id, that is not unique when multiple chart are visualized on the same page.

To Reproduce
Steps to reproduce the behavior:

  1. Add two bar chart visualization, with different width/height sizes (one very small and another very big)
  2. Mouse over the chart and you will see a weird looking highlighter or no highlighter at all

Expected behavior
The highlighter clip path is relative to the chart is using it.

Screenshots
Screenshot 2019-12-09 at 12 23 05

Version (please complete the following information):

  • Elastic Charts: all

Additional context
n/a

Errors in browser console
n/a

Kibana Cross Issues
elastic/kibana#50513

Checklist

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@markov00 markov00 added bug Something isn't working kibana cross issue Has a Kibana issue counterpart labels Dec 9, 2019
@markov00 markov00 self-assigned this Dec 9, 2019
markov00 added a commit to markov00/elastic-charts that referenced this issue Dec 9, 2019
@markov00
fix(highlighter): identify the clipPath using the chartId
755a346 
To uniquely identify the clipPath for the highlighter in a multi-chart page, this commit add the
chartId to the clipPath id

fix elastic#489
@markov00 markov00 mentioned this issue Dec 9, 2019
Merged
2 tasks
markov00 added a commit that referenced this issue Dec 12, 2019
@markov00
fix(highlighter): clip path unique id (#490)
dc93624 
To uniquely identify the clipPath for the highlighter in a multi-chart page, this commit add the
chartId to the clipPath id

fix #489
markov00 pushed a commit that referenced this issue Dec 12, 2019
@semantic-release-bot
chore(release): 15.0.4 [skip ci]
3e049af 
## [15.0.4](v15.0.3...v15.0.4) (2019-12-12)

### Bug Fixes

* **highlighter:** clip path unique id ([#490](#490)) ([dc93624](dc93624)), closes [#489](#489)
@markov00
Copy link
Member Author

🎉 This issue has been resolved in version 15.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Dec 12, 2019
@markov00 markov00 mentioned this issue Dec 13, 2019
Merged
4 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 15.0.4 [skip ci]
e73d8b0 
## [15.0.4](elastic/elastic-charts@v15.0.3...v15.0.4) (2019-12-12)

### Bug Fixes

* **highlighter:** clip path unique id ([opensearch-project#490](elastic/elastic-charts#490)) ([896b93e](elastic/elastic-charts@896b93e)), closes [opensearch-project#489](elastic/elastic-charts#489)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart released Issue released publicly
Projects
None yet
Milestone
No milestone
1 participant
@markov00