Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] unit test api.test.ts is skipped now #490

Closed
ananzh opened this issue Jun 18, 2021 · 0 comments
Closed

[Test] unit test api.test.ts is skipped now #490

ananzh opened this issue Jun 18, 2021 · 0 comments
Assignees
@ananzh
Labels
test:unit v1.0.0

Comments

@ananzh
Copy link
Member

ananzh commented Jun 18, 2021

Describe the bug

Currently, api.test.ts test suite is skipped. To make a clean unit test, we want to explore and decide whether we still need to keep it as skipped.

/src/plugins/newsfeed/public/lib/api.test.ts
Test Suites: 1 skipped, 0 of 1 total
Tests:       18 skipped, 18 total

To Reproduce
Run:yarn test:jest {path to api.test.ts}

Expected behavior
explore the skipped unit tests, check:

  • can we enable all? if yes, create a PR and close the issue

  • can we remove all? if yes, create a PR and close the issue

  • should we keep all? if yes, describe the reasons in the issue.

The final output is expected to be a cleaned unit test with all the skipped ones being checked.

OpenSearch Version
OpenSearch 1.0.0

Dashboards Version
Dashboards 1.0.0
@ananzh ananzh added bug Something isn't working test:unit v1.0.0 untriaged labels Jun 18, 2021
@ananzh ananzh self-assigned this Jun 18, 2021
This was referenced Jun 18, 2021
Merged
Closed
@ananzh ananzh changed the title [BUG] unit test api.test.ts is skipped now [Test] unit test api.test.ts is skipped now Jun 18, 2021
@ananzh ananzh removed untriaged bug Something isn't working labels Jun 18, 2021
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Jun 18, 2021
@ananzh
[Test] Enable unit test suite: api.test.ts (opensearch-project#490)
ed5c8c2 
All the unit tests related to unused newsfeed are temporarily
skipped at forking. To build a clean unit test, we decide to
check and enable all the working unit tests. This PR checks
and enables api.test.ts.

Signed-off-by: Anan Zhuang <[email protected]>
ananzh added a commit that referenced this issue Jun 23, 2021
@ananzh
[Test] Enable unit test suite: api.test.ts (#490) (#495)
d870129 
All the unit tests related to unused newsfeed are temporarily
skipped at forking. To build a clean unit test, we decide to
check and enable all the working unit tests. This PR checks
and enables api.test.ts.

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh closed this as completed Jun 23, 2021
kavilla pushed a commit that referenced this issue Jun 26, 2021
@ananzh @kavilla
[Test] Enable unit test suite: api.test.ts (#490) (#495)
7b08aac 
All the unit tests related to unused newsfeed are temporarily
skipped at forking. To build a clean unit test, we decide to
check and enable all the working unit tests. This PR checks
and enables api.test.ts.

Signed-off-by: Anan Zhuang <[email protected]>
kavilla pushed a commit that referenced this issue Jun 26, 2021
@ananzh @kavilla
[Test] Enable unit test suite: api.test.ts (#490) (#495)
905ff43 
All the unit tests related to unused newsfeed are temporarily
skipped at forking. To build a clean unit test, we decide to
check and enable all the working unit tests. This PR checks
and enables api.test.ts.

Signed-off-by: Anan Zhuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananzh ananzh

Labels
test:unit v1.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ananzh