Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update telemetry test for ODBC stat changes in Elasticsearch #27608

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Update telemetry test for ODBC stat changes in Elasticsearch #27608

merged 2 commits into from
Dec 20, 2018

Conversation

joshdover
Copy link
Contributor

Summary

Updates the expected list of stats returned from local telemetry to reflect the ODBC stat changes in elastic/elasticsearch#36753.

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 Feature:Telemetry v6.6.0 labels Dec 20, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@joshdover joshdover changed the title Update telemetry test for elasticsearch#36753 Update telemetry test for ODBC stat changes in Elasticsearch Dec 20, 2018
@spalger spalger self-requested a review December 20, 2018 17:58
spalger
spalger approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@spalger spalger mentioned this pull request Dec 20, 2018
Merged
2 tasks
@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal
Copy link
Contributor

Looks like this is failing on a Remote Cluster test:

10:19:36                    └- ✖ fail: "apis management remote clusters Remote Clusters List should return an array of remote clusters"
10:19:36                    │ 
10:19:36                    │       Error: expected [ { name: 'test_cluster',
10:19:36                    │     seeds: [ 'localhost:9300' ],
10:19:36                    │     isConnected: true,
10:19:36                    │     connectedNodesCount: 1,
10:19:36                    │     maxConnectionsPerCluster: 3,
10:19:36                    │     initialConnectTimeout: '30s',
10:19:36                    │     skipUnavailable: false,
10:19:36                    │     isConfiguredByNode: false } ] to sort of equal [ { name: 'test_cluster',
10:19:36                    │     seeds: [ '127.0.0.1:9300' ],
10:19:36                    │     isConnected: true,
10:19:36                    │     connectedNodesCount: 1,
10:19:36                    │     maxConnectionsPerCluster: 3,
10:19:36                    │     initialConnectTimeout: '30s',
10:19:36                    │     skipUnavailable: false,
10:19:36                    │     isConfiguredByNode: false } ]
10:19:36                    │       + expected - actual
10:19:36                    │ 
10:19:36                    │            "isConnected": true
10:19:36                    │            "maxConnectionsPerCluster": 3
10:19:36                    │            "name": "test_cluster"
10:19:36                    │            "seeds": [
10:19:36                    │       -      "localhost:9300"
10:19:36                    │       +      "127.0.0.1:9300"
10:19:36                    │            ]
10:19:36                    │            "skipUnavailable": false
10:19:36                    │          }
10:19:36                    │        ]
10:19:36                    │

Looks like this was a mistake on our end. We just need to update the expected value to match what's being returned (https://github.com/elastic/kibana/blob/master/x-pack/test/api_integration/apis/management/remote_clusters/remote_clusters.js#L111).

@joshdover
Copy link
Contributor Author

Talked with @cjcenizal and we decided to disable this test for the time being. It is failing on local environments as well, but in a different way. Will discuss with @sebelga tomorrow.

@cjcenizal cjcenizal mentioned this pull request Dec 20, 2018
Closed
@nreese nreese mentioned this pull request Dec 20, 2018
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joshdover joshdover merged commit 41bbbe3 into elastic:master Dec 20, 2018
@joshdover joshdover deleted the update-telemetry-test branch December 20, 2018 19:44
joshdover added a commit to joshdover/kibana that referenced this pull request Dec 20, 2018
@joshdover
Update telemetry test for ODBC stat changes in Elasticsearch (elastic…
5d3f768 
…#27608)

* Update telemetry test for elasticsearch#36753

* Skip broken remote cluster test for today
@joshdover joshdover mentioned this pull request Dec 20, 2018
Merged
joshdover added a commit to joshdover/kibana that referenced this pull request Dec 20, 2018
@joshdover
Update telemetry test for ODBC stat changes in Elasticsearch (elastic…
43fc711 
…#27608)

* Update telemetry test for elasticsearch#36753

* Skip broken remote cluster test for today
@joshdover joshdover mentioned this pull request Dec 20, 2018
Merged
joshdover added a commit that referenced this pull request Dec 20, 2018
@joshdover
Update telemetry test for ODBC stat changes in Elasticsearch (#27608) (…
3dc6cb9 
…#27619)

* Update telemetry test for elasticsearch#36753

* Skip broken remote cluster test for today
@joshdover
Copy link
Contributor Author

6.6: 3dc6cb9

azasypkin
azasypkin reviewed Dec 21, 2018
View reviewed changes
x-pack/test/api_integration/apis/management/remote_clusters/remote_clusters.js
@@ -109,7 +109,7 @@ export default function ({ getService }) {
});

describe('List', () => {
it('should return an array of remote clusters', async () => {
it.skip('should return an array of remote clusters', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: did we file issue to re-enable this test again?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there is an issue on CCR to investigate: #27616

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be back soon: #27778 😊

@azasypkin
Copy link
Member

6.x/6.7: 14c09fc

@sebelga sebelga mentioned this pull request Dec 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga left review comments

@azasypkin azasypkin azasypkin left review comments

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
backported Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.6.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joshdover @elasticmachine @cjcenizal @azasypkin @spalger @sebelga