-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm Maps App Enabled and License defined before using in App #27607
Conversation
💔 Build Failed |
jenkins, test this |
💔 Build Failed |
I think you will need to rebase with master to get CI to pass (once #27608 is merged). CI failure below sounds like #27608
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with green CI
…ssing license info through to maps app
82b1c60
to
310da22
Compare
💚 Build Succeeded |
💔 Build Failed |
jenkins, test this |
Just thought of one thing that would improve readability. Instead of burying everything under the if clause, maybe just return when plugin is not enabled
|
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the canvas team was tapped due to a bad merge. Since this doesn't involve Canvas at all anymore, my approval here is simply to unblock your PR.
…ssing license info through to maps app (elastic#27607) # Conflicts: # x-pack/plugins/gis/server/routes.js
Resolves #27544. The license info was being assigned correctly, it just hadn't been defined yet. The pieces were in place to wait until the license info had been updated before leveraging the license info, they just hadn't been "hooked up" yet. Also added in a condition that the map app should be enabled.