Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCR] Remote clusters API integration test failure #27616

Closed
cjcenizal opened this issue Dec 20, 2018 · 5 comments
Closed

[CCR] Remote clusters API integration test failure #27616

cjcenizal opened this issue Dec 20, 2018 · 5 comments
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:CCR and Remote Clusters Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test_api

Comments

@cjcenizal
Copy link
Contributor

As discovered in #27608 (comment), the Remote Clusters List API integration test fails on CI. There are two things odd about this:

  1. This test didn't fail originally, so why is it failing now? Possibly this recent ES change relating to address-resolution in remote/info has something to do this it: https://github.com/elastic/elasticsearch/pull/36671/files#diff-d390b91a2cae82a4f90f1386f8428695R679

  2. @joshdover Tried running this test locally and it failed but with a different assertion mismatch. Why are we getting non-deterministic responses back in different environments?

Are these tests operating against actual running clusters? Or are they operating against some sort of mocked clusters? If the former, then I think this partially explains why this test is unreliable. When they were originally written, we probably had a remote cluster running on our machines, so we were making assertions against an environment which differs from the one when the tests are run by CI.

I still don't understand how they were passing in the first place, though. There must have been a cluster running locally on the CI environment, perhaps created by another set of tests?

@cjcenizal cjcenizal added Feature:CCR and Remote Clusters test_api failed-test A test failure on a tracked branch, potentially flaky-test Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Dec 20, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@joshdover
Copy link
Contributor

FYI this test was disabled in master, 6.x, and 6.6 branches.

@joshdover
Copy link
Contributor

@sebelga Were you able to see the same failures I was seeing? In particular I was seeing 0 connected nodes and isConnected: false in the response when running on my machine.

@sebelga
Copy link
Contributor

sebelga commented Dec 26, 2018

@joshdover Not sure what exactly happened on ES side but I updated the seed host in the test and everything is back like it was before. I put you as a reviewer for #27778 but also @jen-huang in case you're on holidays 😊

@jen-huang
Copy link
Contributor

I believe this can be closed now since the fix (#27778) is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:CCR and Remote Clusters Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test_api
Projects
None yet
Development

No branches or pull requests

5 participants