Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FieldFormatters] Add support for rawValue in url label #204192

Conversation

kowalczyk-krzysztof
Copy link
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented Dec 13, 2024

Summary

This PR adds support for {{rawValue}} in url label.

Closes: #188973

@kowalczyk-krzysztof kowalczyk-krzysztof added release_note:skip Skip the PR/issue when compiling release notes Feature:FieldFormatters backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Dec 13, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Dec 13, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof requested a review from a team as a code owner December 13, 2024 11:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fieldFormats 63.2KB 63.2KB +11.0B

cc @kowalczyk-krzysztof

Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kowalczyk-krzysztof kowalczyk-krzysztof merged commit f0d3a44 into elastic:main Dec 13, 2024
18 checks passed
@davismcphee davismcphee added release_note:enhancement backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Dec 13, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12320850664

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12320850669

@davismcphee
Copy link
Contributor

Added the backport:prev-minor label to make sure this lands in 8.x too 🙂

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 13, 2024
## Summary

This PR adds support for ``{{rawValue}}`` in url label.

Closes: elastic#188973
(cherry picked from commit f0d3a44)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 13, 2024
## Summary

This PR adds support for ``{{rawValue}}`` in url label.

Closes: elastic#188973
(cherry picked from commit f0d3a44)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 13, 2024
… (#204271)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[FieldFormatters] Add support for rawValue in url label
(#204192)](#204192)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-13T17:39:05Z","message":"[FieldFormatters]
Add support for rawValue in url label (#204192)\n\n##
Summary\r\n\r\nThis PR adds support for ```` in url
label.\r\n\r\nCloses:
#188973","sha":"f0d3a448eafab076b474a4aef1281be07ed680db","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:FieldFormatters","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"[FieldFormatters]
Add support for rawValue in url
label","number":204192,"url":"https://github.com/elastic/kibana/pull/204192","mergeCommit":{"message":"[FieldFormatters]
Add support for rawValue in url label (#204192)\n\n##
Summary\r\n\r\nThis PR adds support for ```` in url
label.\r\n\r\nCloses:
#188973","sha":"f0d3a448eafab076b474a4aef1281be07ed680db"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204192","number":204192,"mergeCommit":{"message":"[FieldFormatters]
Add support for rawValue in url label (#204192)\n\n##
Summary\r\n\r\nThis PR adds support for ```` in url
label.\r\n\r\nCloses:
#188973","sha":"f0d3a448eafab076b474a4aef1281be07ed680db"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:FieldFormatters release_note:enhancement Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FieldFormatters] Add support for {{rawValue}} in URL label template
5 participants