Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FieldFormatters] Add support for rawValue in url label #204192

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/plugins/field_formats/common/converters/url.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,14 +139,22 @@ describe('UrlFormat', () => {
expect(url.convert('url', TEXT_CONTEXT_TYPE)).toBe('external url');
});

test('can use the raw value', () => {
test('can use the raw value with {{value}}', () => {
const url = new UrlFormat({
labelTemplate: 'external {{value}}',
});

expect(url.convert('url?', TEXT_CONTEXT_TYPE)).toBe('external url?');
});

test('can use the raw value with {{rawValue}}', () => {
const url = new UrlFormat({
labelTemplate: 'external {{rawValue}}',
});

expect(url.convert('url?', TEXT_CONTEXT_TYPE)).toBe('external url?');
});

test('can use the url', () => {
const url = new UrlFormat({
urlTemplate: 'http://google.com/{{value}}',
Expand Down
1 change: 1 addition & 0 deletions src/plugins/field_formats/common/converters/url.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export class UrlFormat extends FieldFormat {
return this.compileTemplate(template)({
value,
url,
rawValue: value,
});
}

Expand Down
Loading