-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FieldFormatters] Add support for {{rawValue}} in URL label template #188973
Comments
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
@jughosta What's the desired behavior here? From what I understand, Should the current behavior be kept and an alias get added so |
Thanks for looking into it! I think we can't simply change the existing behaviour for Adding support for |
## Summary This PR adds support for ``{{rawValue}}`` in url label. Closes: elastic#188973 (cherry picked from commit f0d3a44)
## Summary This PR adds support for ``{{rawValue}}`` in url label. Closes: elastic#188973 (cherry picked from commit f0d3a44)
… (#204271) # Backport This will backport the following commits from `main` to `8.x`: - [[FieldFormatters] Add support for rawValue in url label (#204192)](#204192) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-13T17:39:05Z","message":"[FieldFormatters] Add support for rawValue in url label (#204192)\n\n## Summary\r\n\r\nThis PR adds support for ```` in url label.\r\n\r\nCloses: #188973","sha":"f0d3a448eafab076b474a4aef1281be07ed680db","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:FieldFormatters","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"[FieldFormatters] Add support for rawValue in url label","number":204192,"url":"https://github.com/elastic/kibana/pull/204192","mergeCommit":{"message":"[FieldFormatters] Add support for rawValue in url label (#204192)\n\n## Summary\r\n\r\nThis PR adds support for ```` in url label.\r\n\r\nCloses: #188973","sha":"f0d3a448eafab076b474a4aef1281be07ed680db"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204192","number":204192,"mergeCommit":{"message":"[FieldFormatters] Add support for rawValue in url label (#204192)\n\n## Summary\r\n\r\nThis PR adds support for ```` in url label.\r\n\r\nCloses: #188973","sha":"f0d3a448eafab076b474a4aef1281be07ed680db"}}]}] BACKPORT--> Co-authored-by: Krzysztof Kowalczyk <[email protected]>
When defining a URL template, it's possible to use
{{rawValue}}
for unescaped value. But if{{rawValue}}
is entered into Label template input, it results in missing label for the link.Current workaround is to use
{{value}}
variable for the link label:But it's confusing that
{{rawValue}}
variable is not available for the label template and{{value}}
works as{{rawValue}}
.kibana/src/plugins/field_formats/common/converters/url.ts
Lines 80 to 99 in f388d99
The text was updated successfully, but these errors were encountered: