[Stateful sidenav] Enable on-prem #203239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebelga
added
release_note:enhancement
Feature:Security/Spaces
|
/ci |
sebelga
commented
Dec 6, 2024
| @@ -72,6 +72,7 @@ export const SolutionViewTour: FC<Props> = ({ children, solution, isTourOpen, on | |||
| onFinish={onFinishTour} | |||
| step={1} | |||
| stepsTotal={1} | |||
| repositionOnScroll | |||
There was a problem hiding this comment.
This is to fix an issue when scrolling the window when the tour is open
sebelga
force-pushed
the
stateful-sidenav/enable-onprem
branch
from
fddc285 to
82e94af
Compare
|
/ci |
sebelga
force-pushed
the
stateful-sidenav/enable-onprem
branch
from
82e94af to
3d80b56
Compare
|
/ci |
|
/ci |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
kc13greiner
approved these changes
Dec 10, 2024
| @@ -236,129 +235,34 @@ describe('Spaces plugin', () => { | |||
| }); | |||
|
|
|||
| describe('isSolutionViewEnabled', () => { | |||
| it('when onCloud, not serverless and allowSolutionVisibility is "true"', () => { | |||
| it('when allowSolutionVisibility is "true"', () => { | |||
There was a problem hiding this comment.
Question: should there also be a test for when allowSolutionVisibility is undefined?
There was a problem hiding this comment.
It can't be undefined. It comes from the server yml config that has a default to true.
There was a problem hiding this comment.
With that said, I added a test just in case the server would not provide a value
2fb0eec
mistic
approved these changes
Dec 10, 2024
joemcelroy
approved these changes
Dec 10, 2024
Dosant
approved these changes
Dec 11, 2024
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Page load bundle
History
cc @sebelga |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12277093192 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 11, 2024
(cherry picked from commit 771166b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 11, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Stateful sidenav] Enable on-prem (#203239)](#203239) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T13:12:15Z","message":"[Stateful sidenav] Enable on-prem (#203239)","sha":"771166bf7f95e95bc1e999919f6a75e26e157d0f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Security/Spaces","v9.0.0","Team:SharedUX","backport:prev-minor","Feature:Chrome"],"title":"[Stateful sidenav] Enable on-prem","number":203239,"url":"https://github.com/elastic/kibana/pull/203239","mergeCommit":{"message":"[Stateful sidenav] Enable on-prem (#203239)","sha":"771166bf7f95e95bc1e999919f6a75e26e157d0f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203239","number":203239,"mergeCommit":{"message":"[Stateful sidenav] Enable on-prem (#203239)","sha":"771166bf7f95e95bc1e999919f6a75e26e157d0f"}}]}] BACKPORT--> Co-authored-by: Sébastien Loix <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've enabled the new space solution view (which renders the different solution side navigations) for on-prem users.
How to test
Release notes
The new space solution view is now available for on-prem users. The space solution views allows solution centric navigation similar to our serverless offering.
Fixes #203107