[Spaces] Remove forceSolutionVisibility yml setting #204726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebelga
added
Feature:Security/Spaces
|
/ci |
sebelga
added
release_note:skip
💚 Build Succeeded
Metrics [docs]
cc @sebelga |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Dosant
approved these changes
Dec 18, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12397694916 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 18, 2024
(cherry picked from commit cd3c5b6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 18, 2024
…204805) # Backport This will backport the following commits from `main` to `8.x`: - [[Spaces] Remove forceSolutionVisibility yml setting (#204726)](#204726) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-18T16:58:47Z","message":"[Spaces] Remove forceSolutionVisibility yml setting (#204726)","sha":"cd3c5b6704ce5c97f272e4552c4cfa81cc58f630","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Security/Spaces","release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor"],"title":"[Spaces] Remove forceSolutionVisibility yml setting","number":204726,"url":"https://github.com/elastic/kibana/pull/204726","mergeCommit":{"message":"[Spaces] Remove forceSolutionVisibility yml setting (#204726)","sha":"cd3c5b6704ce5c97f272e4552c4cfa81cc58f630"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204726","number":204726,"mergeCommit":{"message":"[Spaces] Remove forceSolutionVisibility yml setting (#204726)","sha":"cd3c5b6704ce5c97f272e4552c4cfa81cc58f630"}}]}] BACKPORT--> Co-authored-by: Sébastien Loix <[email protected]>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #191743 we introduced a temporary yml setting for the security team so they could enable the new side navigation in their internal deployment.
Since #203239 was merged we don't need this yml setting anymore. We can safely remove it as it was only ever used internally and I checked with the security team to make sure they are not using this setting in their deployment.
Fixes #193132