Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [APM]Refactor ServiceTabEmptyState to use AddDataPanel (#197578) #197666

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[8.x] [APM]Refactor ServiceTabEmptyState to use AddDataPanel (#197578) #197666

merged 1 commit into from
Oct 24, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@iblancof
[APM]Refactor ServiceTabEmptyState to use AddDataPanel (elastic#197578)
ac5fd15 
## Summary

Closes elastic#195876

This PR refactors the ServiceTabEmptyState component to use the newly
created generic AddDataPanel component, which was derived from it.

The functionality remains the same.

### Tabs

|Light|Dark|
|-|-|

|![callout_light](https://github.com/user-attachments/assets/46c7d14b-c4f4-44e4-a753-099abec378e4)|![callout_dark](https://github.com/user-attachments/assets/298386bf-eb76-4b23-9952-df6576032f86)|

### Actions

![callout_actions](https://github.com/user-attachments/assets/08c4364c-c3cb-45af-b02e-5012cbf86536)

### Dismiss

![callout_dismissable](https://github.com/user-attachments/assets/a0276001-98a9-47b3-83c9-aaa0685c7418)

(cherry picked from commit 42de8c8)
@kibanamachine kibanamachine requested review from a team as code owners October 24, 2024 14:39
@kibanamachine kibanamachine enabled auto-merge (squash) October 24, 2024 14:39
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 24, 2024
@kibanamachine kibanamachine mentioned this pull request Oct 24, 2024
Merged
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibanamachine kibanamachine merged commit 9c788b3 into elastic:8.x Oct 24, 2024
32 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB -1.4KB
infra 1.7MB 1.7MB -1.0B
total -1.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityShared 75.1KB 75.1KB -1.0B
Unknown metric groups

ESLint disabled in files

id before after diff
apm 13 12 -1

Total ESLint disabled count

id before after diff
apm 81 80 -1

cc @iblancof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@iblancof iblancof

Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @iblancof