Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Update ServiceTabEmptyState to use AddDataPanel from Observability Shared #195876

Closed
iblancof opened this issue Oct 11, 2024 · 1 comment · Fixed by #197578
Closed

[APM] Update ServiceTabEmptyState to use AddDataPanel from Observability Shared #195876

iblancof opened this issue Oct 11, 2024 · 1 comment · Fixed by #197578
Assignees
@iblancof
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture

Comments

@iblancof
Copy link
Contributor

To enable the use in Infra of an add data panel callout originally developed for APM, we have created a new version in Observability Shared called AddDataPanel.

Image

This issue aims to update APM to integrate the AddDataPanel, which will facilitate the removal of redundant code from ServiceTabEmptyState.

Note

Blocked until #195378 gets merged.
@iblancof iblancof added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture labels Oct 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@iblancof iblancof self-assigned this Oct 23, 2024
@iblancof iblancof mentioned this issue Oct 24, 2024
Merged
iblancof added a commit that referenced this issue Oct 24, 2024
@iblancof
[APM]Refactor ServiceTabEmptyState to use AddDataPanel (#197578)
42de8c8 
## Summary

Closes #195876

This PR refactors the ServiceTabEmptyState component to use the newly
created generic AddDataPanel component, which was derived from it.

The functionality remains the same.

### Tabs

|Light|Dark|
|-|-|

|![callout_light](https://github.com/user-attachments/assets/46c7d14b-c4f4-44e4-a753-099abec378e4)|![callout_dark](https://github.com/user-attachments/assets/298386bf-eb76-4b23-9952-df6576032f86)|

### Actions

![callout_actions](https://github.com/user-attachments/assets/08c4364c-c3cb-45af-b02e-5012cbf86536)

### Dismiss

![callout_dismissable](https://github.com/user-attachments/assets/a0276001-98a9-47b3-83c9-aaa0685c7418)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 24, 2024
@iblancof
[APM]Refactor ServiceTabEmptyState to use AddDataPanel (elastic#197578)
3139b5d 
## Summary

Closes elastic#195876

This PR refactors the ServiceTabEmptyState component to use the newly
created generic AddDataPanel component, which was derived from it.

The functionality remains the same.

### Tabs

|Light|Dark|
|-|-|

|![callout_light](https://github.com/user-attachments/assets/46c7d14b-c4f4-44e4-a753-099abec378e4)|![callout_dark](https://github.com/user-attachments/assets/298386bf-eb76-4b23-9952-df6576032f86)|

### Actions

![callout_actions](https://github.com/user-attachments/assets/08c4364c-c3cb-45af-b02e-5012cbf86536)

### Dismiss

![callout_dismissable](https://github.com/user-attachments/assets/a0276001-98a9-47b3-83c9-aaa0685c7418)

(cherry picked from commit 42de8c8)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 24, 2024
@iblancof
[APM]Refactor ServiceTabEmptyState to use AddDataPanel (elastic#197578)
ac5fd15 
## Summary

Closes elastic#195876

This PR refactors the ServiceTabEmptyState component to use the newly
created generic AddDataPanel component, which was derived from it.

The functionality remains the same.

### Tabs

|Light|Dark|
|-|-|

|![callout_light](https://github.com/user-attachments/assets/46c7d14b-c4f4-44e4-a753-099abec378e4)|![callout_dark](https://github.com/user-attachments/assets/298386bf-eb76-4b23-9952-df6576032f86)|

### Actions

![callout_actions](https://github.com/user-attachments/assets/08c4364c-c3cb-45af-b02e-5012cbf86536)

### Dismiss

![callout_dismissable](https://github.com/user-attachments/assets/a0276001-98a9-47b3-83c9-aaa0685c7418)

(cherry picked from commit 42de8c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iblancof iblancof

Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM]Refactor ServiceTabEmptyState to use AddDataPanel iblancof/kibana
2 participants
@elasticmachine @iblancof