[APM]Refactor ServiceTabEmptyState to use AddDataPanel #197578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancof
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
cauemarcondes
changed the title
cauemarcondes
approved these changes
Oct 24, 2024
...k/plugins/observability_solution/apm/public/components/app/service_tab_empty_state/index.tsx
Outdated
Show resolved
Hide resolved
…-use-add-data-panel-from-observability-shared
jennypavlova
approved these changes
Oct 24, 2024
...lugins/observability_solution/apm/public/components/app/service_tab_empty_state/constants.ts
Outdated
Show resolved
Hide resolved
...lugins/observability_solution/apm/public/components/app/service_tab_empty_state/constants.ts
Outdated
Show resolved
Hide resolved
...lugins/observability_solution/apm/public/components/app/service_tab_empty_state/constants.ts
Outdated
Show resolved
Hide resolved
| @@ -97,7 +97,7 @@ export function ServiceOverview() { | |||
| <EuiFlexItem> | |||
| <ServiceTabEmptyState | |||
| id="serviceOverview" | |||
| onDissmiss={() => setDismissedLogsOnlyEmptyState(true)} | |||
| onDismiss={() => setDismissedLogsOnlyEmptyState(true)} | |||
There was a problem hiding this comment.
Thanks for fixing the typo!
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
cc @iblancof |
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11501550405 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
## Summary Closes elastic#195876 This PR refactors the ServiceTabEmptyState component to use the newly created generic AddDataPanel component, which was derived from it. The functionality remains the same. ### Tabs |Light|Dark| |-|-| ||| ### Actions  ### Dismiss  (cherry picked from commit 42de8c8)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
## Summary Closes elastic#195876 This PR refactors the ServiceTabEmptyState component to use the newly created generic AddDataPanel component, which was derived from it. The functionality remains the same. ### Tabs |Light|Dark| |-|-| ||| ### Actions  ### Dismiss  (cherry picked from commit 42de8c8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
… (#197665) # Backport This will backport the following commits from `main` to `8.16`: - [[APM]Refactor ServiceTabEmptyState to use AddDataPanel (#197578)](#197578) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T14:34:55Z","message":"[APM]Refactor ServiceTabEmptyState to use AddDataPanel (#197578)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195876\r\n\r\nThis PR refactors the ServiceTabEmptyState component to use the newly\r\ncreated generic AddDataPanel component, which was derived from it.\r\n\r\nThe functionality remains the same.\r\n\r\n### Tabs\r\n\r\n|Light|Dark|\r\n|-|-|\r\n\r\n|||\r\n\r\n### Actions\r\n\r\n\r\n\r\n### Dismiss\r\n\r\n","sha":"42de8c858995b190f35858b2798f7ea4dfcb2439","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","apm","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0","v8.17.0"],"title":"[APM]Refactor ServiceTabEmptyState to use AddDataPanel","number":197578,"url":"https://github.com/elastic/kibana/pull/197578","mergeCommit":{"message":"[APM]Refactor ServiceTabEmptyState to use AddDataPanel (#197578)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195876\r\n\r\nThis PR refactors the ServiceTabEmptyState component to use the newly\r\ncreated generic AddDataPanel component, which was derived from it.\r\n\r\nThe functionality remains the same.\r\n\r\n### Tabs\r\n\r\n|Light|Dark|\r\n|-|-|\r\n\r\n|||\r\n\r\n### Actions\r\n\r\n\r\n\r\n### Dismiss\r\n\r\n","sha":"42de8c858995b190f35858b2798f7ea4dfcb2439"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197578","number":197578,"mergeCommit":{"message":"[APM]Refactor ServiceTabEmptyState to use AddDataPanel (#197578)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195876\r\n\r\nThis PR refactors the ServiceTabEmptyState component to use the newly\r\ncreated generic AddDataPanel component, which was derived from it.\r\n\r\nThe functionality remains the same.\r\n\r\n### Tabs\r\n\r\n|Light|Dark|\r\n|-|-|\r\n\r\n|||\r\n\r\n### Actions\r\n\r\n\r\n\r\n### Dismiss\r\n\r\n","sha":"42de8c858995b190f35858b2798f7ea4dfcb2439"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Irene Blanco <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
#197666) # Backport This will backport the following commits from `main` to `8.x`: - [[APM]Refactor ServiceTabEmptyState to use AddDataPanel (#197578)](#197578) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T14:34:55Z","message":"[APM]Refactor ServiceTabEmptyState to use AddDataPanel (#197578)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195876\r\n\r\nThis PR refactors the ServiceTabEmptyState component to use the newly\r\ncreated generic AddDataPanel component, which was derived from it.\r\n\r\nThe functionality remains the same.\r\n\r\n### Tabs\r\n\r\n|Light|Dark|\r\n|-|-|\r\n\r\n|||\r\n\r\n### Actions\r\n\r\n\r\n\r\n### Dismiss\r\n\r\n","sha":"42de8c858995b190f35858b2798f7ea4dfcb2439","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","apm","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0","v8.17.0"],"title":"[APM]Refactor ServiceTabEmptyState to use AddDataPanel","number":197578,"url":"https://github.com/elastic/kibana/pull/197578","mergeCommit":{"message":"[APM]Refactor ServiceTabEmptyState to use AddDataPanel (#197578)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195876\r\n\r\nThis PR refactors the ServiceTabEmptyState component to use the newly\r\ncreated generic AddDataPanel component, which was derived from it.\r\n\r\nThe functionality remains the same.\r\n\r\n### Tabs\r\n\r\n|Light|Dark|\r\n|-|-|\r\n\r\n|||\r\n\r\n### Actions\r\n\r\n\r\n\r\n### Dismiss\r\n\r\n","sha":"42de8c858995b190f35858b2798f7ea4dfcb2439"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197578","number":197578,"mergeCommit":{"message":"[APM]Refactor ServiceTabEmptyState to use AddDataPanel (#197578)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195876\r\n\r\nThis PR refactors the ServiceTabEmptyState component to use the newly\r\ncreated generic AddDataPanel component, which was derived from it.\r\n\r\nThe functionality remains the same.\r\n\r\n### Tabs\r\n\r\n|Light|Dark|\r\n|-|-|\r\n\r\n|||\r\n\r\n### Actions\r\n\r\n\r\n\r\n### Dismiss\r\n\r\n","sha":"42de8c858995b190f35858b2798f7ea4dfcb2439"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Irene Blanco <[email protected]>
iblancof
deleted the
195876-apm-update-service-tab-empty-state-to-use-add-data-panel-from-observability-shared
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #195876
This PR refactors the ServiceTabEmptyState component to use the newly created generic AddDataPanel component, which was derived from it.
The functionality remains the same.
Tabs
Actions
Dismiss