[Onboarding]Update manage indices button in index management to navigate to search_indices details page #196787
Conversation
saarikabhasi
added
backport:prev-minor
saarikabhasi
force-pushed
the
update-index-list-actions
branch
from
24a3363 to
6f3b582
Compare
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7177[✅] x-pack/test_serverless/functional/test_suites/search/config.feature_flags.ts: 25/25 tests passed. |
update CI check search_indices plugin
saarikabhasi
force-pushed
the
update-index-list-actions
branch
from
6aa3c83 to
1bff218
Compare
|
Can we remove the title from the popover? It's redundant with the 'Manage' button action |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7182[✅] x-pack/test_serverless/functional/test_suites/search/config.feature_flags.ts: 25/25 tests passed. |
x-pack/test_serverless/functional/test_suites/search/search_index_detail.ts
Show resolved
Hide resolved
@mdefazio I think we may need to check with appEX team before we make the change? |
saarikabhasi
force-pushed
the
update-index-list-actions
branch
from
78e86cd to
e58ca29
Compare
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7188[✅] x-pack/test_serverless/functional/test_suites/search/config.feature_flags.ts: 25/25 tests passed. |
|
This is a bug fix for functionality introduced in 8.16.0, right? If so, it would be nice to link to the PR (and issue?) that they're following up. I'm sure I'm lacking some context since I'm new to the team but it would also be nice to for anyone else who's unfamiliar. |
x-pack/plugins/index_management/public/application/services/routing.ts
Outdated
Show resolved
Hide resolved
|
Looks good to me and works well but I'm going to see if another teammate can look as well since this is my first time looking at this code. |
There was a problem hiding this comment.
Adding a second review from @elastic/kibana-management team. I tested it locally and everything works as expected. As for the code changes, I have no additional comments beyond agreeing with @mattkime's suggestions. It would be great to address those.
saarikabhasi
force-pushed
the
update-index-list-actions
branch
from
3e5fadf to
2ecafde
Compare
x-pack/test_serverless/functional/test_suites/common/management/index_management/indices.ts
Show resolved
Hide resolved
I apologize I had missed to link ticket |
saarikabhasi
force-pushed
the
update-index-list-actions
branch
from
7290e8e to
3de0c5f
Compare
x-pack/plugins/index_management/public/application/services/routing.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11499864843 |
…ate to search_indices details page (elastic#196787) In this PR, updating manage indices button to navigate to search_indices details page. https://github.com/user-attachments/assets/29868c2d-7c6f-4895-b5e7-b5dea161c09a ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit f25ef61)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
… navigate to search_indices details page (#196787) (#197634) # Backport This will backport the following commits from `main` to `8.x`: - [[Onboarding]Update manage indices button in index management to navigate to search_indices details page (#196787)](#196787) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Saarika Bhasi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T13:02:54Z","message":"[Onboarding]Update manage indices button in index management to navigate to search_indices details page (#196787)\n\nIn this PR, updating manage indices button to navigate to search_indices\r\ndetails page.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29868c2d-7c6f-4895-b5e7-b5dea161c09a\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"f25ef61d52ded8e3cdbc00704f0425cb0536a92d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Onboarding]Update manage indices button in index management to navigate to search_indices details page","number":196787,"url":"https://github.com/elastic/kibana/pull/196787","mergeCommit":{"message":"[Onboarding]Update manage indices button in index management to navigate to search_indices details page (#196787)\n\nIn this PR, updating manage indices button to navigate to search_indices\r\ndetails page.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29868c2d-7c6f-4895-b5e7-b5dea161c09a\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"f25ef61d52ded8e3cdbc00704f0425cb0536a92d"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196787","number":196787,"mergeCommit":{"message":"[Onboarding]Update manage indices button in index management to navigate to search_indices details page (#196787)\n\nIn this PR, updating manage indices button to navigate to search_indices\r\ndetails page.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29868c2d-7c6f-4895-b5e7-b5dea161c09a\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"f25ef61d52ded8e3cdbc00704f0425cb0536a92d"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Saarika Bhasi <[email protected]>
In this PR, updating manage indices button to navigate to search_indices details page.
demo.mov
Checklist