Skip to content

Commit

Permalink
CI FTR tests clean up
Browse files Browse the repository at this point in the history
update CI check search_indices plugin
  • Loading branch information
saarikabhasi committed Oct 18, 2024
1 parent 6f3b582 commit 1bff218
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion x-pack/plugins/search_indices/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export class SearchIndicesPlugin
indexManagement?.extensionsService.setIndexDetailsPageRoute({
renderRoute: (indexName, detailsTabId) => {
const route = `/app/elasticsearch/indices/index_details/${indexName}`;
const tabIds:string[] = Object.values(SearchIndexDetailsTabs)
const tabIds: string[] = Object.values(SearchIndexDetailsTabs);
if (detailsTabId && tabIds.includes(detailsTabId)) {
return `${route}/${detailsTabId}`;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,13 @@ export function SvlSearchIndexDetailPageProvider({ getService }: FtrProviderCont
await testSubjects.existOrFail('showMappingsIndexMenuButton');
await testSubjects.existOrFail('deleteIndexMenuButton');
},
async changeManageIndexTab(manageIndexTab: 'showOverviewIndexMenuButton' | 'showSettingsIndexMenuButton' | 'showMappingsIndexMenuButton'| 'deleteIndexMenuButton') {
async changeManageIndexTab(
manageIndexTab:
| 'showOverviewIndexMenuButton'
| 'showSettingsIndexMenuButton'
| 'showMappingsIndexMenuButton'
| 'deleteIndexMenuButton'
) {
await testSubjects.existOrFail(manageIndexTab);
const manageIndexComponent = await testSubjects.find(manageIndexTab);
await manageIndexComponent.click();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await pageObjects.indexManagement.changeTabs('indicesTab');
await pageObjects.header.waitUntilLoadingHasFinished();
});
after(async () => {
await esDeleteAllIndices(indexName);
});
describe('manage index action', () => {
beforeEach(async () => {
await pageObjects.svlSearchIndexDetailPage.manageIndex();
Expand Down

0 comments on commit 1bff218

Please sign in to comment.