clean ups

elastic · Oct 18, 2024 · 6f3b582 · 6f3b582
1 parent f72f42c
commit 6f3b582
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/...ication/sections/home/index_list/index_actions_context_menu/index_actions_context_menu.js b/...ication/sections/home/index_list/index_actions_context_menu/index_actions_context_menu.js
@@ -89,7 +89,8 @@ export class IndexActionsContextMenu extends Component {
             extensionsService,
             application,
             http,
-            history
+            history,
+            IndexDetailsSection.Overview
           );
         },
       });

diff --git a/x-pack/plugins/index_management/public/application/services/routing.ts b/x-pack/plugins/index_management/public/application/services/routing.ts
@@ -92,11 +92,9 @@ export const navigateToIndexDetailsPage = (
   tabId?: IndexDetailsSection
 ) => {
   if (!extensionsService.indexDetailsPageRoute) {
-    history.push(
-      getIndexDetailsLink(indexName, indicesListURLParams, IndexDetailsSection.Overview)
-    );
+    history.push(getIndexDetailsLink(indexName, indicesListURLParams, tabId));
   } else {
     const route = extensionsService.indexDetailsPageRoute.renderRoute(indexName, tabId);
-    application.navigateToUrl(http.basePath.prepend(`${route}`));
+    application.navigateToUrl(http.basePath.prepend(route));
   }
 };
diff --git a/x-pack/plugins/search_indices/public/plugin.ts b/x-pack/plugins/search_indices/public/plugin.ts
@@ -90,12 +90,12 @@ export class SearchIndicesPlugin
     if (this.pluginEnabled) {
       indexManagement?.extensionsService.setIndexDetailsPageRoute({
         renderRoute: (indexName, detailsTabId) => {
-          const route = `/app/elasticsearch/indices/index_details/${indexName}`
-          if(detailsTabId && Object.values(SearchIndexDetailsTabs).includes(detailsTabId)){
-            return `${route}/${detailsTabId}`
+          const route = `/app/elasticsearch/indices/index_details/${indexName}`;
+          const tabIds:string[] = Object.values(SearchIndexDetailsTabs)
+          if (detailsTabId && tabIds.includes(detailsTabId)) {
+            return `${route}/${detailsTabId}`;
           }
-          return route
-
+          return route;
         },
       });
     }