Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Posture] Adding CSP 3P support callout for Wiz integration #196025

Merged
merged 5 commits into from
Oct 14, 2024
Merged

[Cloud Posture] Adding CSP 3P support callout for Wiz integration #196025

merged 5 commits into from
Oct 14, 2024

Conversation

JordanSh
Copy link
Contributor

@JordanSh JordanSh commented Oct 13, 2024 •
edited by kibanamachine
Loading

Summary

Part of #187230

Callout will only be displayed on Wiz integration and on the condition that the user has not dismissed the callout already

Screen.Recording.2024-10-13.at.15.33.34.mov

@JordanSh JordanSh added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 13, 2024
@JordanSh JordanSh self-assigned this Oct 13, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 13, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #49 / Machine Learning anomaly detectors POST anomaly_detectors _forecast with spaces should delete forecast for user with permissions

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 1210 1211 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +1.4KB

History

cc @JordanSh

@JordanSh JordanSh marked this pull request as ready for review October 14, 2024 09:17
@JordanSh JordanSh requested a review from a team as a code owner October 14, 2024 09:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@JordanSh JordanSh requested a review from juliaElastic October 14, 2024 09:17
maxcold
maxcold reviewed Oct 14, 2024
View reviewed changes
...ins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/overview.tsx Outdated
const LS_CLOUD_POSTURE_3P_SUPPORT_WIZ_INTEGRATIONS_CALLOUT_KEY =
'fleet:cloudSecurityPosture:thirdPartySupport:wizIntegrationsCallout';

const CloudPostureThirdPartySupportCallout = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about having this component in its own file so we can add it to our team ownership? I would also pass the package name to it so that all the logic was inside the component, again to eliminate the risk smth being changed outside our our ownership. Ofc there always be the risk that the call of the component is deleted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, makes sense

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

juliaElastic
juliaElastic approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, agree with Maxim's comment about moving it to a separate file.

@JordanSh JordanSh requested a review from maxcold October 14, 2024 10:25
@JordanSh JordanSh enabled auto-merge (squash) October 14, 2024 11:56
@JordanSh JordanSh merged commit ebe16fa into elastic:main Oct 14, 2024
29 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11327653280

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Response Ops][Rules] Version Mute All Rule API (#195572)
- [Onboarding][Auto-detect] Update design for supported integrations badges (#195351)
- [Onboarding] only update the index details page when plugin is enabled (#196077)
- [Search][Ent Search deprecation] Web Crawler tile points out GH repo instead become disabled (#194743)
- Upgrade EUI to v97.0.0 (#195525)
- [Cloud Security] handle both rule.references and rule.reference in misconfiguraiton flyout (#195932)
- [ResponseOps][Rules] Fix case action templates in stack for security serverless (#195763)
- [CI] Add timeouts for retries for docker image build (#195915)
- [Side navigation] bring back getIsActive to o11y solution navigation (#196057)
- [Search][Ent Search deprecation] Removing indices stats tiles (#193968)

Manual backport

To create the backport manually run:

node scripts/backport --pr 196025

Questions ?

Please refer to the Backport tool documentation

@JordanSh JordanSh removed the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Oct 14, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 14, 2024
@JordanSh JordanSh added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Oct 14, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11328640919

@JordanSh JordanSh added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Oct 14, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11331077224

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11331077204

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Stateful sidenav] Fix collapsed menu for panels with no landing pages (#195904)
- [DataUsage][Serverless] Data usage metrics page enhancements (#195556)
- [Lens] Disable config axis side and color picker when groupid is breakdown and collaseFn enable (#195845)
- [Data Usage] Added AutoOps API service (#195844)
- chore(quality-gates): update manual judgement on staging QGs (#195944)

Manual backport

To create the backport manually run:

node scripts/backport --pr 196025

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Stateful sidenav] Fix collapsed menu for panels with no landing pages (#195904)
- [DataUsage][Serverless] Data usage metrics page enhancements (#195556)
- [Lens] Disable config axis side and color picker when groupid is breakdown and collaseFn enable (#195845)
- [Data Usage] Added AutoOps API service (#195844)
- chore(quality-gates): update manual judgement on staging QGs (#195944)

Manual backport

To create the backport manually run:

node scripts/backport --pr 196025

Questions ?

Please refer to the Backport tool documentation

@JordanSh JordanSh removed the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Oct 15, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 15, 2024
@JordanSh JordanSh added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Oct 15, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11341996622

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11341996601

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 196025

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Lens] Disable config axis side and color picker when groupid is breakdown and collaseFn enable (#195845)
- chore(quality-gates): update manual judgement on staging QGs (#195944)

Manual backport

To create the backport manually run:

node scripts/backport --pr 196025

Questions ?

Please refer to the Backport tool documentation

This was referenced Oct 15, 2024
Merged
Merged
@JordanSh JordanSh removed the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Oct 15, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 15, 2024
@JordanSh JordanSh added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Oct 15, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11344141978

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11344141813

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 196025

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 196025

Questions ?

Please refer to the Backport tool documentation

@JordanSh JordanSh mentioned this pull request Oct 15, 2024
Merged
@JordanSh
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

JordanSh added a commit to JordanSh/kibana that referenced this pull request Oct 15, 2024
@JordanSh
[Cloud Posture] Adding CSP 3P support callout for Wiz integration (el…
fa2f83c 
…astic#196025)

(cherry picked from commit ebe16fa)
JordanSh added a commit that referenced this pull request Oct 15, 2024
@JordanSh @kibanamachine
[8.x] [Cloud Posture] Adding CSP 3P support callout for Wiz integrati…
60d3fef 
…on (#196025) (#196274)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Cloud Posture] Adding CSP 3P support callout for Wiz integration
(#196025)](#196025)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jordan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T12:35:25Z","message":"[Cloud
Posture] Adding CSP 3P support callout for Wiz integration
(#196025)","sha":"ebe16fa467d6e35e2398ad724780db05c27779cf","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Cloud
Security","backport:prev-minor"],"number":196025,"url":"https://github.com/elastic/kibana/pull/196025","mergeCommit":{"message":"[Cloud
Posture] Adding CSP 3P support callout for Wiz integration
(#196025)","sha":"ebe16fa467d6e35e2398ad724780db05c27779cf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196025","number":196025,"mergeCommit":{"message":"[Cloud
Posture] Adding CSP 3P support callout for Wiz integration
(#196025)","sha":"ebe16fa467d6e35e2398ad724780db05c27779cf"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
@JordanSh JordanSh mentioned this pull request Oct 22, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

@maxcold maxcold maxcold approved these changes

Assignees

@JordanSh JordanSh

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related Team:Fleet Team label for Observability Data Collection Fleet team v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JordanSh @elasticmachine @kibanamachine @maxcold @juliaElastic