-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add timeouts for retries for docker image build #195915
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delanni
added
Team:Operations
Team label for Operations Team
release_note:skip
Skip the PR/issue when compiling release notes
backport:prev-major
Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development
labels
Oct 11, 2024
delanni
changed the title
add sleep between retries for kibana docker image build
[CI] Add timeouts for retries for docker image build
Oct 11, 2024
Pinging @elastic/kibana-operations (Team:Operations) |
Ikuni17
approved these changes
Oct 11, 2024
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
|
Starting backport for target branches: 8.15, 8.x https://github.com/elastic/kibana/actions/runs/11326127162 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
## Summary The generated version of the docker image builder script didn't have timeouts between retries, so a temporary outage on `docker.elastic.co` would cause a docker pull error, failing the build (see: https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978) This PR adds a fix 15s per retry to the docker build runner. (cherry picked from commit 1bd8144)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
## Summary The generated version of the docker image builder script didn't have timeouts between retries, so a temporary outage on `docker.elastic.co` would cause a docker pull error, failing the build (see: https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978) This PR adds a fix 15s per retry to the docker build runner. (cherry picked from commit 1bd8144)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
…196108) # Backport This will backport the following commits from `main` to `8.x`: - [[CI] Add timeouts for retries for docker image build (#195915)](#195915) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T10:57:07Z","message":"[CI] Add timeouts for retries for docker image build (#195915)\n\n## Summary\r\nThe generated version of the docker image builder script didn't have\r\ntimeouts between retries, so a temporary outage on `docker.elastic.co`\r\nwould cause a docker pull error, failing the build (see:\r\nhttps://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)\r\n\r\nThis PR adds a fix 15s per retry to the docker build runner.","sha":"1bd81449242a1ab57e82c211808753e82f25c92c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:prev-major","ci:build-cloud-image"],"title":"[CI] Add timeouts for retries for docker image build","number":195915,"url":"https://github.com/elastic/kibana/pull/195915","mergeCommit":{"message":"[CI] Add timeouts for retries for docker image build (#195915)\n\n## Summary\r\nThe generated version of the docker image builder script didn't have\r\ntimeouts between retries, so a temporary outage on `docker.elastic.co`\r\nwould cause a docker pull error, failing the build (see:\r\nhttps://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)\r\n\r\nThis PR adds a fix 15s per retry to the docker build runner.","sha":"1bd81449242a1ab57e82c211808753e82f25c92c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195915","number":195915,"mergeCommit":{"message":"[CI] Add timeouts for retries for docker image build (#195915)\n\n## Summary\r\nThe generated version of the docker image builder script didn't have\r\ntimeouts between retries, so a temporary outage on `docker.elastic.co`\r\nwould cause a docker pull error, failing the build (see:\r\nhttps://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)\r\n\r\nThis PR adds a fix 15s per retry to the docker build runner.","sha":"1bd81449242a1ab57e82c211808753e82f25c92c"}}]}] BACKPORT--> Co-authored-by: Alex Szabo <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
…#196107) # Backport This will backport the following commits from `main` to `8.15`: - [[CI] Add timeouts for retries for docker image build (#195915)](#195915) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T10:57:07Z","message":"[CI] Add timeouts for retries for docker image build (#195915)\n\n## Summary\r\nThe generated version of the docker image builder script didn't have\r\ntimeouts between retries, so a temporary outage on `docker.elastic.co`\r\nwould cause a docker pull error, failing the build (see:\r\nhttps://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)\r\n\r\nThis PR adds a fix 15s per retry to the docker build runner.","sha":"1bd81449242a1ab57e82c211808753e82f25c92c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:prev-major","ci:build-cloud-image"],"title":"[CI] Add timeouts for retries for docker image build","number":195915,"url":"https://github.com/elastic/kibana/pull/195915","mergeCommit":{"message":"[CI] Add timeouts for retries for docker image build (#195915)\n\n## Summary\r\nThe generated version of the docker image builder script didn't have\r\ntimeouts between retries, so a temporary outage on `docker.elastic.co`\r\nwould cause a docker pull error, failing the build (see:\r\nhttps://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)\r\n\r\nThis PR adds a fix 15s per retry to the docker build runner.","sha":"1bd81449242a1ab57e82c211808753e82f25c92c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195915","number":195915,"mergeCommit":{"message":"[CI] Add timeouts for retries for docker image build (#195915)\n\n## Summary\r\nThe generated version of the docker image builder script didn't have\r\ntimeouts between retries, so a temporary outage on `docker.elastic.co`\r\nwould cause a docker pull error, failing the build (see:\r\nhttps://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)\r\n\r\nThis PR adds a fix 15s per retry to the docker build runner.","sha":"1bd81449242a1ab57e82c211808753e82f25c92c"}}]}] BACKPORT--> Co-authored-by: Alex Szabo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-major
Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development
ci:build-cloud-image
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v8.15.3
v8.16.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The generated version of the docker image builder script didn't have timeouts between retries, so a temporary outage on
docker.elastic.co
would cause a docker pull error, failing the build (see: https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4845#01927b40-43f9-471e-9e2c-407320fac978)This PR adds a fix 15s per retry to the docker build runner.