Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiz integration - add info box #187230

Closed
2 tasks done
JordanSh opened this issue Jul 1, 2024 · 6 comments
Closed
2 tasks done

Wiz integration - add info box #187230

JordanSh opened this issue Jul 1, 2024 · 6 comments
Assignees
Labels
8.17 candidate Feature:Cloud-Security Cloud Security related features Team:Cloud Security Cloud Security team related

Comments

@JordanSh
Copy link
Contributor

JordanSh commented Jul 1, 2024

Summary

Image

We would like users to be informed about the new capabilities for their Wiz integrations by adding a info box prompting this information

Definition of Done

  • Add the info box using native EuiCallout
  • Store its display state in local storage, the callout should not pop for users who already closed the box previously

Related Links

@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 1, 2024
@JordanSh JordanSh added Team:Cloud Security Cloud Security team related 8.16 candidate and removed needs-team Issues missing a team label labels Jul 1, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kfirpeled kfirpeled added the Feature:Cloud-Security Cloud Security related features label Jul 18, 2024
@JordanSh JordanSh self-assigned this Aug 7, 2024
@acorretti acorretti changed the title [Cloud Security] Wiz integration - add info box Wiz integration - add info box Sep 19, 2024
@JordanSh
Copy link
Contributor Author

In [Cloud Posture] Adding CSP 3P support callout for Wiz integration #196025 the UI changes to kibana have been merged to have the callout above the integration description.
The issue is still open until the integration changes will be merged

@maxcold
Copy link
Contributor

maxcold commented Oct 29, 2024

Updating Wiz integration page is also a part of this issue. Here are some comments:

  • Description will be updated according to the Figma mocks. But we shouldn't link within the stack to our Findings page. The description is part of the README which is just a markdown, it supports either external links or anchor links to the same document. Kibana url might have a custom base path, such as /kbn and we don't have a way to get it from this readme. Linking to cspm/cnvm public should be suffecient and actually makes more sense in my opinion anyway
  • screenshot will be added
  • adding links to our flows in Assets is not possible without custom code on Kibana code. I think we shouldn't invest time into that, as it doesn't scale to many integrations anyway, we don't want to ask 3rd party integration owners to make changes to Kibana for such a small gain from the UX perspective

@JordanSh
Copy link
Contributor Author

thank you @maxcold for adding the changes to the integration into the 2.0.0 release PR

@JordanSh
Copy link
Contributor Author

[Cloud Security] release Wiz version 2.0.0 added the changes to the description and images.

Assets links were left out due to the reasons @maxcold listed in this comment above.

Closing this ticket

@opauloh
Copy link
Contributor

opauloh commented Nov 4, 2024

Verified

8.16.0 BC 2

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.17 candidate Feature:Cloud-Security Cloud Security related features Team:Cloud Security Cloud Security team related
Projects
None yet
Development

No branches or pull requests

6 participants