[Fleet] Disable button in logstash output based on correct privileges #195210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criamico
added
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
reviewed
Oct 7, 2024
| @@ -76,7 +77,7 @@ const CollapsibleCallout: React.FunctionComponent<EuiCallOutProps> = ({ children | |||
| /> | |||
| </EuiButton> | |||
| ) : ( | |||
| <EuiButton onClick={() => setIsOpen(true)} fill={true}> | |||
| <EuiButton onClick={() => setIsOpen(true)} fill={true} disabled={!hasAllSettings}> | |||
There was a problem hiding this comment.
nit: I added a MissingPrivilegesToolTip in #195185 that you can use to display a tooltip on why it's disabled
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @criamico |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11218254372 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2024
…elastic#195210) Fixes elastic#191951 ## Summary Disable button in logstash output based on correct privileges. ### Testing - Enable feature flag `subfeaturePrivileges` - Follow testing steps in above ticket The button "view steps" in logstash output should be disabled if role doesn'thave `fleet.allSettings` privileges   ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 71c8d6f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2024
…ileges (#195210) (#195275) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Disable button in logstash output based on correct privileges (#195210)](#195210) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cristina Amico","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-07T14:57:08Z","message":"[Fleet] Disable button in logstash output based on correct privileges (#195210)\n\nFixes https://github.com/elastic/kibana/issues/191951\r\n\r\n## Summary\r\nDisable button in logstash output based on correct privileges.\r\n\r\n### Testing \r\n- Enable feature flag `subfeaturePrivileges`\r\n- Follow testing steps in above ticket\r\nThe button \"view steps\" in logstash output should be disabled if role\r\ndoesn'thave `fleet.allSettings` privileges\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"71c8d6fddcb5abd32ece23c0b0c74a766691ca34","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","v8.16.0","backport:version"],"title":"[Fleet] Disable button in logstash output based on correct privileges","number":195210,"url":"https://github.com/elastic/kibana/pull/195210","mergeCommit":{"message":"[Fleet] Disable button in logstash output based on correct privileges (#195210)\n\nFixes https://github.com/elastic/kibana/issues/191951\r\n\r\n## Summary\r\nDisable button in logstash output based on correct privileges.\r\n\r\n### Testing \r\n- Enable feature flag `subfeaturePrivileges`\r\n- Follow testing steps in above ticket\r\nThe button \"view steps\" in logstash output should be disabled if role\r\ndoesn'thave `fleet.allSettings` privileges\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"71c8d6fddcb5abd32ece23c0b0c74a766691ca34"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195210","number":195210,"mergeCommit":{"message":"[Fleet] Disable button in logstash output based on correct privileges (#195210)\n\nFixes https://github.com/elastic/kibana/issues/191951\r\n\r\n## Summary\r\nDisable button in logstash output based on correct privileges.\r\n\r\n### Testing \r\n- Enable feature flag `subfeaturePrivileges`\r\n- Follow testing steps in above ticket\r\nThe button \"view steps\" in logstash output should be disabled if role\r\ndoesn'thave `fleet.allSettings` privileges\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"71c8d6fddcb5abd32ece23c0b0c74a766691ca34"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cristina Amico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191951
Summary
Disable button in logstash output based on correct privileges.
Testing
subfeaturePrivilegesThe button "view steps" in logstash output should be disabled if role doesn'thave
fleet.allSettingsprivilegesChecklist