[Fleet] Do not enable uninstall command link without Agents:All #195185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: cc @nchaulet |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11214025972 |
1 task
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2024
…tic#195185) (cherry picked from commit 3c1c646)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2024
…#195185) (#195222) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Do not enable uninstall command link without Agents:All (#195185)](#195185) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-07T10:54:38Z","message":"[Fleet] Do not enable uninstall command link without Agents:All (#195185)","sha":"3c1c64678b142c36535e6db0810d8d02467489cc","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Fleet] Do not enable uninstall command link without Agents:All","number":195185,"url":"https://github.com/elastic/kibana/pull/195185","mergeCommit":{"message":"[Fleet] Do not enable uninstall command link without Agents:All (#195185)","sha":"3c1c64678b142c36535e6db0810d8d02467489cc"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195185","number":195185,"mergeCommit":{"message":"[Fleet] Do not enable uninstall command link without Agents:All (#195185)","sha":"3c1c64678b142c36535e6db0810d8d02467489cc"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #192055
Do not enable uninstall command link when user do not have Agents:All, we also show a tooltip explaining why it's disabled
UI Change